Bump the dnspython version to 2.4.2#16150
Merged
Merged
Conversation
ghost
added
FlorentClarret
force-pushed
the
florentclarret/dns_check/bump_dnspython
branch
2 times, most recently
from
c11180e to
8defd4d
Compare
Contributor
FlorentClarret
force-pushed
the
florentclarret/dns_check/bump_dnspython
branch
from
8defd4d to
733aed4
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
FlorentClarret
force-pushed
the
florentclarret/dns_check/bump_dnspython
branch
3 times, most recently
from
d233c39 to
e3bf2e6
Compare
3 tasks
FlorentClarret
force-pushed
the
florentclarret/dns_check/bump_dnspython
branch
2 times, most recently
from
b4e9c41 to
8d4de32
Compare
FlorentClarret
force-pushed
the
florentclarret/dns_check/bump_dnspython
branch
from
8d4de32 to
561ad77
Compare
alopezz
reviewed
Nov 6, 2023
| assert answer.rrset.items[0].to_text() | ||
|
|
||
| items = list(answer.rrset.items.keys()) if PY3 else answer.rrset.items | ||
| assert items[0].to_text() |
Contributor
There was a problem hiding this comment.
I wonder if what was originally intended was something like
Suggested change
| assert items[0].to_text() | |
| assert any(it.to_text() for it in items) |
That would make it independent of whether it's a list or a dict, and would seem easier to understand (otherwise, some comment explaining why the first element is so important here would be in order).
Member
Author
There was a problem hiding this comment.
I don't have the background, let's do it that way
Contributor
There was a problem hiding this comment.
Now items can be answer.rrset.items without needing to check PY3, right?
alopezz
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump the dnspython version to 2.4.2 on Python 3.
I also paramtrized a test and adapted the mocks
Motivation
itemsfrom a list to a dictAdditional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.