Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README templates #10564

Merged
merged 5 commits into from
Nov 8, 2021
Merged

Update README templates #10564

merged 5 commits into from
Nov 8, 2021

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Nov 5, 2021 •
edited
Loading

What does this PR do?

This PR updates the integration README templates to generate the correct links for each type of integration and repo.

Motivation

Before, directions for installing the Datadog Agent weren't standardized. This resulted in integrations linking to different pages on how to install the Agent. See #10529 to view fixes of old integration.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@yzhan289 yzhan289 marked this pull request as ready for review November 5, 2021 18:10
@yzhan289 yzhan289 requested review from a team as code owners November 5, 2021 18:10
@codecov
Copy link

codecov bot commented Nov 5, 2021 •
edited
Loading

Codecov Report

Merging #10564 (345690c) into master (459e8c1) will decrease coverage by 0.00%.
The diff coverage is 81.81%.

Flag Coverage Δ
datadog_checks_dev 79.77% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

sarah-witt
sarah-witt requested changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

datadog_checks_dev/datadog_checks/dev/tooling/create.py Show resolved Hide resolved
sarah-witt
sarah-witt approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

ruthnaebeck
ruthnaebeck approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@yzhan289 yzhan289 merged commit 9b1f0b7 into master Nov 8, 2021
@yzhan289 yzhan289 deleted the az/readme-template branch November 8, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

Assignees
No one assigned
Labels
dev/tooling documentation integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yzhan289 @ruthnaebeck @sarah-witt @ChristineTChen