From effe70e2565325c641b5c1d16d40fe1774ddd614 Mon Sep 17 00:00:00 2001 From: David Blewett Date: Thu, 20 Jan 2022 13:59:00 -0500 Subject: [PATCH] PR feedback fixes. --- clippy.toml | 1 - glommio/src/executor/mod.rs | 10 ++++++---- 2 files changed, 6 insertions(+), 5 deletions(-) delete mode 100644 clippy.toml diff --git a/clippy.toml b/clippy.toml deleted file mode 100644 index ba34bf464..000000000 --- a/clippy.toml +++ /dev/null @@ -1 +0,0 @@ -too-many-arguments-threshold = 8 diff --git a/glommio/src/executor/mod.rs b/glommio/src/executor/mod.rs index f8df679b2..96c87051a 100644 --- a/glommio/src/executor/mod.rs +++ b/glommio/src/executor/mod.rs @@ -79,6 +79,8 @@ use crate::{ Reactor, Shares, }; +#[cfg(doc)] +use crate::executor::stall::DefaultStallDetectionHandler; use ahash::AHashMap; pub(crate) const DEFAULT_EXECUTOR_NAME: &str = "unnamed"; @@ -475,7 +477,7 @@ pub struct LocalExecutorBuilder { /// executor blocking_thread_pool_placement: PoolPlacement, /// Whether to detect stalls in unyielding tasks. - /// DefaultStallDetectionHandler installs a signal handler for SIGUSR1, so + /// [`DefaultStallDetectionHandler`] installs a signal handler for SIGUSR1, so /// is disabled by default. detect_stalls: Option>, } @@ -578,7 +580,7 @@ impl LocalExecutorBuilder { } /// Whether to detect stalls in unyielding tasks. - /// DefaultStallDetectionHandler installs a signal handler for SIGUSR1, so + /// [`DefaultStallDetectionHandler`] installs a signal handler for SIGUSR1, so /// is disabled by default. /// # Examples /// @@ -768,7 +770,7 @@ pub struct LocalExecutorPoolBuilder { /// placement strategy as its host executor blocking_thread_pool_placement: PoolPlacement, /// Factory function to generate the stall detection handler. - /// DefaultStallDetectionHandler installs a signal handler for SIGUSR1, so + /// [`DefaultStallDetectionHandler installs`] a signal handler for SIGUSR1, so /// is disabled by default. handler_gen: Option Box>>, } @@ -880,7 +882,7 @@ impl LocalExecutorPoolBuilder { /// Whether to detect stalls in unyielding tasks. /// This method takes a closure of `handler_gen`, which will be called on /// each new thread to generate the stall detection handler to be used in - /// that executor. DefaultStallDetectionHandler installs a signal + /// that executor. [`DefaultStallDetectionHandler`] installs a signal /// handler for SIGUSR1, so is disabled by default. /// # Examples ///