minor js fixes & name chunks

Author: davidejones

src/scripts/components/async-loading.js

@@ -205,7 +205,7 @@ function loadPage(newUrl) {
             gtag('config', gaTag, { page_path: pathName });
 
             // Marketo
-            if (typeof window.Munchkin !== 'undefined') {
+            if (typeof window.Munchkin !== 'undefined' && typeof window.Munchkin.munchkinFunction === 'function') {
                 window.Munchkin.munchkinFunction('clickLink', { href: newUrl });
             } else {
                 window.DD_LOGS.logger.info('Munchkin called before ready..');

src/scripts/components/security-rules.js

@@ -23,7 +23,8 @@ export function initializeSecurityRules() {
         let results = [];
 
         if (filterCategoryValue && filterCategoryValue !== 'all') {
-            results = document.querySelectorAll(`.${filterCategoryValue}`);
+            const val = (filterCategoryValue.startsWith('.')) ? filterCategoryValue.slice(1) : filterCategoryValue;
+            results = document.querySelectorAll(`.${val}`);
         } else {
             results = allRules;
         }
@@ -54,10 +55,13 @@ export function initializeSecurityRules() {
 
     const handleEmptyResultSet = () => {
         const searchQuery = inputSearch.value;
-        const activeCategoryFilter = stringToTitleCase(document.querySelector('.controls .active').text);
+        const txt = (document.querySelector('.controls .active')) ? document.querySelector('.controls .active').text : '';
+        const activeCategoryFilter = stringToTitleCase(txt);
         const message = `No results found for query "${searchQuery}" in category ${activeCategoryFilter}`;
-        jsEmptyResults.innerText = message;
-        jsEmptyResults.classList.remove('d-none');
+        if(jsEmptyResults) {
+          jsEmptyResults.innerText = message;
+          jsEmptyResults.classList.remove('d-none');
+        }
     }
 
     const showResults = (filteredResults) => {
@@ -77,7 +81,7 @@ export function initializeSecurityRules() {
         // Handle empty result set
         if (filteredResults.length < 1) {
             handleEmptyResultSet();
-        } else {
+        } else if (jsEmptyResults) {
             jsEmptyResults.innerText = '';
             jsEmptyResults.classList.add('d-none');
         }
@@ -92,11 +96,11 @@ export function initializeSecurityRules() {
         })
     }
 
-    const handleCategoryFilterClick = (event) => {       
+    const handleCategoryFilterClick = (event) => {
         // If button is already active, or an operation is in progress, ignore the click
         if (event.target.classList.contains('active') || !event.target.getAttribute('data-filter'))
             return;
-            
+
         const searchValue = inputSearch.value.length > 2 ? inputSearch.value.toLowerCase().trim() : '';
         const filtered = filterResults(event.target.dataset.filter, searchValue);
         activateButton(event.target, filters);
@@ -105,7 +109,8 @@ export function initializeSecurityRules() {
 
     const handleKeyup = () => {
         const searchValue = inputSearch.value.length > 2 ? inputSearch.value.toLowerCase().trim() : '';
-        const activeCategoryFilter = document.querySelector('.controls .active').dataset.filter;
+        const activeCategory = document.querySelector('.controls .active');
+        const activeCategoryFilter = (activeCategory) ? activeCategory.dataset.filter : '';
         const { hash } = window.location;
         const replaceUrl = hash ? `?q=${searchValue}${hash}` : `?q=${searchValue}`
 
@@ -150,4 +155,4 @@ export function initializeSecurityRules() {
         activateButton(activeFilterButton, filters);
         showResults(filtered);
     }
-}
+}

webpack.common.js

@@ -43,7 +43,11 @@ const commonConfig = env => {
         },
         output: {
             path: path.join(__dirname, 'public', 'static'),
-            publicPath: 'static'
+            publicPath: 'static',
+            chunkFilename:
+                  process.env.NODE_ENV === 'preview' || process.env.NODE_ENV === 'production'
+                      ? '[name].[chunkhash].js'
+                      : '[name].js'
         },
 
         context: path.join(__dirname, 'src'),