Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datadog::Correlation usage improvements #664

Merged
merged 3 commits into from
Dec 27, 2018
Merged

Datadog::Correlation usage improvements #664

merged 3 commits into from
Dec 27, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Dec 21, 2018 •
edited
Loading

Makes some minor modifications to correlations:

  • Renamed Tracer#active_correlation_ids to active_correlation
  • #trace_id and #span_id return 0 instead of nil from Correlation::Identifier for inactive traces.
  • Added more documentation explaining explicit requirements for correlation logging.

@delner delner added core Involves Datadog core libraries feature Involves a product feature labels Dec 21, 2018
@delner delner added this to the 0.19.0 milestone Dec 21, 2018
@delner delner self-assigned this Dec 21, 2018
@brettlangdon
Copy link
Member

@palazzem this is ready for your review

@delner delner requested a review from palazzem December 21, 2018 20:21
palazzem
palazzem approved these changes Dec 27, 2018
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me. Let's be consistent with other languages.

@delner delner merged commit b44ccbc into 0.19-dev Dec 27, 2018
@delner delner deleted the feature/correlation_usage_improvements branch December 27, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

@palazzem palazzem palazzem approved these changes

Assignees

@delner delner

Labels
core Involves Datadog core libraries feature Involves a product feature
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@delner @brettlangdon @palazzem