Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Rack integration configuration #541

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Implement Rack integration configuration #541

merged 1 commit into from
Sep 17, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Sep 14, 2018

This pull request implements the configuration core from #450 in the Rack integration.

@delner delner added integrations Involves tracing integrations dev/refactor Involves refactoring existing components labels Sep 14, 2018
@delner delner self-assigned this Sep 14, 2018
@delner delner force-pushed the refactor/rack_integration_configuration branch from 16f5006 to f2b53f5 Compare September 14, 2018 20:50
@pawelchcki
Copy link
Contributor

Looks like it fails some tests:

  1) Error:
TracedRackAPITest#test_traced_api_404_with_rack:
NoMethodError: undefined method `reset_options!' for #<Datadog::Contrib::Rack::Integration:0x00000001b73d28>
    /app/test/contrib/grape/rack_app.rb:53:in `teardown'

Otherwise looks good :)

@delner
Copy link
Contributor Author

delner commented Sep 17, 2018 •
edited
Loading

@pawelchcki yup, going to fix those real quick.

@delner delner force-pushed the refactor/rack_integration_configuration branch from f2b53f5 to 082bc22 Compare September 17, 2018 14:25
@pawelchcki pawelchcki self-requested a review September 17, 2018 14:58
pawelchcki
pawelchcki approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@delner delner force-pushed the refactor/rack_integration_configuration branch from 082bc22 to 6801a0d Compare September 17, 2018 15:11
@delner delner merged commit 03ab65f into refactor/upgrade_to_integration_configuration Sep 17, 2018
@delner delner deleted the refactor/rack_integration_configuration branch September 17, 2018 15:12
@delner delner mentioned this pull request Sep 20, 2018
Merged
26 tasks
delner added a commit that referenced this pull request Sep 21, 2018
@delner
Refactored: Rack to use Datadog::Contrib::Integration. (#541)
8c1e7ea
delner added a commit that referenced this pull request Sep 21, 2018
@delner
Refactored: Rack to use Datadog::Contrib::Integration. (#541)
67eec25
delner added a commit that referenced this pull request Sep 21, 2018
@delner
Refactored: Rack to use Datadog::Contrib::Integration. (#541)
e0dfbe5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelchcki pawelchcki pawelchcki approved these changes

Assignees

@delner delner

Labels
dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @pawelchcki