Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version to Integration #483

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Add version to Integration #483

merged 1 commit into from
Jul 24, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Jul 12, 2018

This pull request adds #version and #present? to Datadog::Contrib::Patchable to expose version numbers in a more consistent manner.

@delner delner added core Involves Datadog core libraries integrations Involves tracing integrations feature Involves a product feature labels Jul 12, 2018
@delner delner self-assigned this Jul 12, 2018
@delner delner requested a review from pawelchcki July 12, 2018 15:46
@delner delner added this to the 0.14.0 milestone Jul 13, 2018
pawelchcki
pawelchcki approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is a step in the right direction.
Lets merge it. :LGTM:

@pawelchcki pawelchcki merged commit 3630e3d into 0.14-dev Jul 24, 2018
@delner delner deleted the feature/add_version_to_integration branch August 14, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelchcki pawelchcki pawelchcki approved these changes

Assignees

@delner delner

Labels
core Involves Datadog core libraries feature Involves a product feature integrations Involves tracing integrations
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @pawelchcki