Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min_spans_before_partial_flush option setting #397

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Fix min_spans_before_partial_flush option setting #397

merged 1 commit into from
Apr 10, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Apr 10, 2018 •
edited
Loading

Looks like we accidentally gave this setting the wrong value.

@delner delner changed the title Fix wrong min_spans_before partial flush option setting Fix min_spans_before_partial_flush option setting Apr 10, 2018
@delner delner requested a review from palazzem April 10, 2018 17:30
@delner delner self-assigned this Apr 10, 2018
@delner delner added bug Involves a bug core Involves Datadog core libraries labels Apr 10, 2018
@delner delner added this to the 0.12.0 milestone Apr 10, 2018
@delner delner changed the base branch from master to 0.12-dev April 10, 2018 17:31
palazzem
palazzem approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@palazzem palazzem merged commit 2b6f562 into 0.12-dev Apr 10, 2018
@palazzem palazzem deleted the bugfix/wrong_min_spans_before_partial_flush_option_setting branch April 10, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees

@delner delner

Labels
bug Involves a bug core Involves Datadog core libraries
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @palazzem