Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ActiveSupport::Notifications::Subscriber with Racecar #381

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Use ActiveSupport::Notifications::Subscriber with Racecar #381

merged 1 commit into from
Mar 26, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Mar 21, 2018 •
edited
Loading

This pull request refactors the Racecar integration to use the ActiveSupport::Notifications::Subscriber module.

Is currently base on the parent PR #380, which must be merged first.

@delner delner mentioned this pull request Mar 21, 2018
Merged
@delner
Copy link
Contributor Author

delner commented Mar 21, 2018

@dasch Here's the updated Racecar integration. Let me know what you think!

@delner delner self-assigned this Mar 21, 2018
@delner delner added the integrations Involves tracing integrations label Mar 21, 2018
@delner delner mentioned this pull request Mar 21, 2018
Closed
@delner delner force-pushed the feature/use_active_support_subscriber_with_racecar branch from c6257ff to 4a270ee Compare March 22, 2018 16:03
@palazzem palazzem added this to the 0.12.0 milestone Mar 26, 2018
@palazzem palazzem force-pushed the feature/use_active_support_subscriber_with_racecar branch from 4a270ee to 46d919b Compare March 26, 2018 09:01
@palazzem
Copy link
Contributor

@delner I've rebased and force-pushed the branch on top of the current 0.12-dev. Doing the release now.

palazzem
palazzem approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me. I'd say to keep other integrations the way they are (i.e. ActiveRecord), and proceed with a refactoring only when it's needed.

@palazzem palazzem merged commit 7828c76 into 0.12-dev Mar 26, 2018
@palazzem palazzem deleted the feature/use_active_support_subscriber_with_racecar branch March 26, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasch dasch dasch approved these changes

@palazzem palazzem palazzem approved these changes

@p-lambert p-lambert Awaiting requested review from p-lambert

Assignees

@delner delner

Labels
integrations Involves tracing integrations
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@delner @palazzem @dasch