Skip to content

[NO-TICKET] Optimize CodeProvenance#record_loaded_files to avoid allocations #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[NO-TICKET] Optimize CodeProvenance#record_loaded_files to avoid allocations #3757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/datadog/profiling/collectors/code_provenance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,10 @@ def record_loaded_files(loaded_files)

seen_files << file_path

_, found_library = libraries_by_path.find { |library_path, _| file_path.start_with?(library_path) }
seen_libraries << found_library if found_library
# NOTE: Don't use .find, it allocates a lot more memory (see commit that added this note for details)
libraries_by_path.any? do |library_path, library|
seen_libraries << library if file_path.start_with?(library_path)
end
end
end

Expand Down