Add http.base_url tag to Rack #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
enhancement
integrations
delner
force-pushed
the
delner/change_http_url_tag_to_include_host
branch
from
a65a3ae
to
0f1056b
Compare
palazzem
force-pushed
the
delner/change_http_url_tag_to_include_host
branch
from
0f1056b
to
a3f6704
Compare
palazzem
reviewed
Jan 27, 2018
| @@ -20,16 +20,14 @@ def initialize(app) | |||
| def call(env) | |||
| # retrieve integration settings | |||
| tracer = Datadog.configuration[:rack][:tracer] | |||
| service = Datadog.configuration[:rack][:service_name] | |||
| distributed_tracing = Datadog.configuration[:rack][:distributed_tracing] | |||
There was a problem hiding this comment.
Removed this variables since they're used once (reducing the method's length)
| if status.to_s.start_with?('5') && request_span.status.zero? | ||
| request_span.status = 1 | ||
| end | ||
| set_request_tags!(request_span, env, status, headers, response) |
There was a problem hiding this comment.
to reduce the method Abc complexity, I've moved these actions in a separated method that updates in place request_span. It's just moving, though the logic is still the same.
palazzem
approved these changes
Jan 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
http.base_urltag for Rack integrations, which is the equivalent ofRack::Request#base_url, e.g. "http://example.org" Addresses #301