[PROF-7307] Enable allocation counting feature by default for some Ruby 3 versions #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by 3 versions **What does this PR do?** This PR enables the Profiler's `allocation_counting_enabled` feature by default for some Ruby 3 versions. (This feature depends on the profiler itself being enabled). TL;DR we were already enabling this feature by default on Ruby 2, but did not do it on Ruby 3 because of a VM bug ( https://bugs.ruby-lang.org/issues/18464 ). Now that this VM bug has been fixed for some Ruby versions (3.1.4, 3.2.3, 3.3.0), we can enable it by default again. **Motivation:** The allocation counting feature is required to enable other features in the future (including allocation profiling) and thus we want to allow as many customers as possible to have it. **Additional Notes:** There's a second annoying VM bug that can also break `allocation_counting_enabled` (https://bugs.ruby-lang.org/issues/19112) but since that bug doesn't cause a VM crash and only makes it so that data collection stops for this feature, I think we can live with it for now. I'm also reaching out through some contacts to see if we can get the other bug fixed soon (and possibly backported). **How to test the change?** Change includes test coverage.
Codecov Report
@@ Coverage Diff @@
## master #3176 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 1247 1247
Lines 71713 71724 +11
Branches 3340 3338 -2
==========================================
+ Hits 70381 70390 +9
- Misses 1332 1334 +2 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ekump
approved these changes
Oct 3, 2023
ivoanjo
deleted the
ivoanjo/prof-7307-enable-allocation-counting-fixed-ruby-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables the Profiler's
allocation_counting_enabledfeature by default for some Ruby 3 versions.(This feature depends on the profiler itself being enabled).
TL;DR we were already enabling this feature by default on Ruby 2, but did not do it on Ruby 3 because of a VM bug
( https://bugs.ruby-lang.org/issues/18464 ).
Now that this VM bug has been fixed for some Ruby versions (3.1.4, 3.2.3, 3.3.0), we can enable it by default again.
Motivation:
The allocation counting feature is required to enable other features in the future (including allocation profiling) and thus we want to allow as many customers as possible to have it.
Additional Notes:
There's a second annoying VM bug that can also break
allocation_counting_enabled(https://bugs.ruby-lang.org/issues/19112) but since that bug doesn't cause a VM crash and only makes it so that data collection stops for this feature, I think we can live with it for now.I'm also reaching out through some contacts to see if we can get the other bug fixed soon (and possibly backported).
How to test the change?
Change includes test coverage.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.