Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROF-4198] Gather CPU time in profiler without monkey patching Thread for all supported Ruby versions (2.1 to 3.x) #1740

Merged
merged 14 commits into from
Nov 5, 2021
Merged

[PROF-4198] Gather CPU time in profiler without monkey patching Thread for all supported Ruby versions (2.1 to 3.x) #1740

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2d6e9c5
Enable gathering thread CPU time using native extension for legacy Ru…
ivoanjo Oct 26, 2021
a9f9354
Introduce NativeExtension#cpu_time_ns_for helper
ivoanjo Oct 27, 2021
87c9676
Sample cpu time in Stack sampler using native extension directly
ivoanjo Oct 27, 2021
2ce9dc4
Copy Process::Waiter comments and regression tests over from cthread.rb
ivoanjo Oct 27, 2021
50ad4f5
Remove all references to the CPU extension from the Setup task
ivoanjo Oct 26, 2021
1106b71
Remove all references to the CPU time extension aka Thread monkey patch
ivoanjo Oct 27, 2021
09dd419
Add info banner when native extension build is being skipped
ivoanjo Oct 27, 2021
e85f017
Drop ffi dependency
ivoanjo Oct 27, 2021
9a77c61
Skip building the profiling native extension on TruffleRuby
ivoanjo Oct 27, 2021
eb8ff20
Skip native extension build testing for Windows+ruby-head
ivoanjo Oct 27, 2021
b47bdbb
Workaround for Ruby 2.1 not having a public thread_native.h header
ivoanjo Oct 27, 2021
e1c4fa3
Add missing test assertions
ivoanjo Oct 27, 2021
0f7eeae
Use nicer helper to detect Linux
ivoanjo Oct 28, 2021
4725cc6
Pin version of `debase-ruby_core_source` used, as discussed during PR…
ivoanjo Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove all references to the CPU time extension aka Thread monkey patch 
It's been fully replaced by our usage of the native extension to get
this information.
  • Loading branch information
@ivoanjo
ivoanjo committed Oct 27, 2021
commit 1106b71e74ac54120175f09b43a3e24147ea4ccb
2 changes: 0 additions & 2 deletions lib/ddtrace/profiling.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,7 @@ def self.unsupported_reason
private_class_method def self.load_profiling
return false unless supported?

require 'ddtrace/profiling/ext/cpu'
require 'ddtrace/profiling/ext/forking'

require 'ddtrace/profiling/collectors/stack'
require 'ddtrace/profiling/exporter'
require 'ddtrace/profiling/recorder'
Expand Down
67 changes: 0 additions & 67 deletions lib/ddtrace/profiling/ext/cpu.rb
View file
Open in desktop

This file was deleted.

172 changes: 0 additions & 172 deletions lib/ddtrace/profiling/ext/cthread.rb
View file
Open in desktop

This file was deleted.

Loading