[PROF-4084] Send profile duration and start in pprof to enable UX to show duration #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…show duration By setting the `duration_nanos`, we enable the UX to show profile duration. Since we "were in the neighbourhood", I also set the `time_nanos` which corresponds to the profile start.
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
=======================================
Coverage 98.18% 98.19%
=======================================
Files 934 934
Lines 45046 45067 +21
=======================================
+ Hits 44230 44253 +23
+ Misses 816 814 -2
Continue to review full report at Codecov.
|
marcotc
reviewed
Oct 6, 2021
| string_table: @string_table.strings | ||
| string_table: @string_table.strings, | ||
| time_nanos: start_ns, | ||
| duration_nanos: finish_ns - start_ns, |
There was a problem hiding this comment.
Ahaha I remember Kotlin 1.4 adding a lot of great improvements and I was like "KOTLIN 1.4 HAS TRAILING COMMA I DON'T CARE ABOUT ANYTHING ELSE!!!!!!!!!"
marcotc
reviewed
Oct 6, 2021
marcotc
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the
duration_nanos, we enable the UX to show profile duration.Since we "were in the neighbourhood", I also set the
time_nanoswhich corresponds to the profile start.