Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined method `stop' for #<Datadog::SyncWriter ... #914

Closed
Yurokle opened this issue Jan 9, 2020 · 2 comments · Fixed by #915
Closed

undefined method `stop' for #<Datadog::SyncWriter ... #914

Yurokle opened this issue Jan 9, 2020 · 2 comments · Fixed by #915
Assignees
@marcotc
Labels
bug Involves a bug community Was opened by a community member core Involves Datadog core libraries
Milestone
0.31.1

Comments

@Yurokle
Copy link

Yurokle commented Jan 9, 2020

Hello. I'm seeing the exception below when I'm running some rake tasks.

Traceback (most recent call last):
	1: from /Users/ynaidyon/.rvm/gems/ruby-2.6.5/gems/ddtrace-0.31.0/lib/ddtrace.rb:33:in `block in <module:Datadog>'
/Users/ynaidyon/.rvm/gems/ruby-2.6.5/gems/ddtrace-0.31.0/lib/ddtrace/tracer.rb:53:in `shutdown!': undefined method `stop' for #<Datadog::SyncWriter:0x00007fb29f827680> (NoMethodError)

It looks like Datadog::SyncWorker doesn't implement #stop method which Tracer#shutdown! is trying to call here: https://github.com/DataDog/dd-trace-rb/blob/master/lib/ddtrace/tracer.rb#L53
@marcotc marcotc mentioned this issue Jan 9, 2020
Merged
@marcotc
Copy link
Member

marcotc commented Jan 9, 2020

Thank you for the issue report @Yurokle!

I was able to reproduce and create a pull request to address this issue: #915

@marcotc marcotc self-assigned this Jan 9, 2020
@marcotc marcotc added bug Involves a bug community Was opened by a community member core Involves Datadog core libraries labels Jan 9, 2020
@Yurokle
Copy link
Author

Yurokle commented Jan 9, 2020

Thanks @marcotc !

@marcotc marcotc added this to the 0.31.1 milestone Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcotc marcotc

Labels
bug Involves a bug community Was opened by a community member core Involves Datadog core libraries
Projects
None yet
Milestone
0.31.1
Development

Successfully merging a pull request may close this issue.

Add SyncWriter#stop method DataDog/dd-trace-rb
2 participants
@Yurokle @marcotc