Skip to content

patch process_action including filters #787

Open

Description

This is in reference to this action here: https://github.com/DataDog/dd-trace-rb/blob/b69dca3532453e99b5bd26183bf89bedeab9a8aa/lib/ddtrace/contrib/rails/action_controller_patch.rb .

I'm encountering this inconsistency, at least according to my expectation, where the action controller tracer only pertains to the action itself. I think it makes sense that this tracer should include the filters (before_action, after_action).

My use case is: I want to augment the current span in an after_action, instead of "polluting" the controller action with datadog tracer calls. However I can't do this, because there is no active_span when the after action is triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

communityWas opened by a community memberfeature-requestA request for a new feature or change to an existing oneintegrationsInvolves tracing integrations

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions