Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of google-protobuf not being loaded when profiler starts #2523

Closed
ivoanjo opened this issue Jan 5, 2023 · 1 comment
Closed
Assignees
Labels
bug Involves a bug

Comments

@ivoanjo
Copy link
Member

ivoanjo commented Jan 5, 2023

Current behaviour

In #1552 we added some code to improve the error message around an issue that a customer found but that we could not reproduce at the time.

In #1552 (comment) we finally got an example of how and why the issue triggers.

Expected behaviour

We should provide a good error message explaining what happened and how to fix it, rather than the vague "please report this message".

Steps to reproduce

See #1552 (comment) .

@ivoanjo ivoanjo added bug Involves a bug community Was opened by a community member and removed community Was opened by a community member labels Jan 5, 2023
@ivoanjo ivoanjo self-assigned this Jan 5, 2023
@ivoanjo
Copy link
Member Author

ivoanjo commented Jun 27, 2023

Update on this one: With the migration to the new Ruby CPU Profiling 2.0, we don't need google-protobuf anymore. Thus, I don't think it's worth touching the loading code, as we plan on removing it soon.

@ivoanjo ivoanjo closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug
Projects
None yet
Development

No branches or pull requests

1 participant