From fec401b2bc3720963bccdc50a9edd247881c457a Mon Sep 17 00:00:00 2001 From: Robert Pankowecki Date: Tue, 30 Aug 2022 12:00:28 +0200 Subject: [PATCH] Faraday middleware uses HttpAnnotationHelper service_name(env[:url].host, options) was called but the result was not used. --- lib/datadog/tracing/contrib/faraday/middleware.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/datadog/tracing/contrib/faraday/middleware.rb b/lib/datadog/tracing/contrib/faraday/middleware.rb index 56b26cefe6b..fcd16e65a9a 100644 --- a/lib/datadog/tracing/contrib/faraday/middleware.rb +++ b/lib/datadog/tracing/contrib/faraday/middleware.rb @@ -39,8 +39,7 @@ def call(env) def annotate!(span, env, options) span.resource = resource_name(env) - service_name(env[:url].host, options) - span.service = options[:split_by_domain] ? env[:url].host : options[:service_name] + span.service = service_name(env[:url].host, options) span.span_type = Tracing::Metadata::Ext::HTTP::TYPE_OUTBOUND span.set_tag(Tracing::Metadata::Ext::TAG_COMPONENT, Ext::TAG_COMPONENT)