Faraday middleware uses HttpAnnotationHelper

service_name(env[:url].host, options) was called but the result was not used.
DataDog · Aug 30, 2022 · fec401b · fec401b
1 parent 87cb8ad
commit fec401b
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/datadog/tracing/contrib/faraday/middleware.rb b/lib/datadog/tracing/contrib/faraday/middleware.rb
@@ -39,8 +39,7 @@ def call(env)
 
           def annotate!(span, env, options)
             span.resource = resource_name(env)
-            service_name(env[:url].host, options)
-            span.service = options[:split_by_domain] ? env[:url].host : options[:service_name]
+            span.service = service_name(env[:url].host, options)
             span.span_type = Tracing::Metadata::Ext::HTTP::TYPE_OUTBOUND
 
             span.set_tag(Tracing::Metadata::Ext::TAG_COMPONENT, Ext::TAG_COMPONENT)