From 3da4cfd992810b308900d8c32bceb37183a9d924 Mon Sep 17 00:00:00 2001 From: Robin Schroer Date: Thu, 22 Aug 2024 01:16:42 +0900 Subject: [PATCH] Fix confusion in the SpanFilter docstring (#3851) The docstring was claiming that a truthy value from the filter block keeps the span, but in fact it's the other way around, a truthy value drops the span. --- lib/datadog/tracing/pipeline/span_filter.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/datadog/tracing/pipeline/span_filter.rb b/lib/datadog/tracing/pipeline/span_filter.rb index 494978fe7e..74b1c562a7 100644 --- a/lib/datadog/tracing/pipeline/span_filter.rb +++ b/lib/datadog/tracing/pipeline/span_filter.rb @@ -10,8 +10,8 @@ module Pipeline # This processor executes the configured `operation` for each {Datadog::Tracing::Span} # in a {Datadog::Tracing::TraceSegment}. # - # If `operation` returns a truthy value for a span, that span is kept, - # otherwise the span is removed from the trace. + # If `operation` returns a truthy value for a span, that span is dropped, + # otherwise the span is kept. # # @public_api class SpanFilter < SpanProcessor