Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci_visibility): support pytest 8.0.0 [backport 2.4] #8481

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

romainkomorndatadog
Copy link
Collaborator

Backport 78d5b98 from #8357 to 2.4.

Addresses #8220 and fixes an issue with pytest 8.x and above
(brought by pytest-dev/pytest#11137 ) where pytest.Package objects no longer have an attached module attribute.

This also changes the testing matrix to include version ~=8.0, but maintains ~=7.0 as a separate testing environment.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 22, 2024

Datadog Report

Branch report: backport-8357-to-2.4
Commit report: 93e8dd8
Test service: dd-trace-py

❌ 1 Failed (0 Known Flaky), 95410 Passed, 971 Skipped, 10h 56m 10.12s Total duration (1h 12m 44.28s time saved)

❌ Failed Tests (1)

  • test_build_schema - test_schema_fuzz.py - Details

    Expand for error
     Hypothesis test_build_schema(obj={-1.175494351e-38: {'\x91': [18422,
        [],
        nan,
        {},
        {1.175494351e-38: 8697},
        True,
        None]}}
     # Saw 1 signaling NaN) produces unreliable results: Falsified on the first call but did not on a subsequent one
    

@romainkomorndatadog romainkomorndatadog merged commit 70a8d53 into 2.4 Feb 22, 2024
142 checks passed
@romainkomorndatadog romainkomorndatadog deleted the backport-8357-to-2.4 branch February 22, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants