-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci_visibility): support pytest 8.0.0 #8357
fix(ci_visibility): support pytest 8.0.0 #8357
Conversation
BenchmarksBenchmark execution time: 2024-02-15 13:14:51 Comparing candidate commit c53be90 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 173 metrics, 9 unstable metrics. |
…s_no_path' of github.com:DataDog/dd-trace-py into romain.komorn/CIVIS-8969/fix_civis_crash_when_module_has_no_path
…n_module_has_no_path
…s_no_path' of github.com:DataDog/dd-trace-py into romain.komorn/CIVIS-8969/fix_civis_crash_when_module_has_no_path
The weeds are getting a bit deeper. I need to rewrite everything that touches We have long-delayed plans to introduce an API to centralize all the span/event creation into the That does mean slowing down the response to #8220 , but it should be better for the long term. |
Datadog ReportBranch report: ✅ 0 Failed, 171710 Passed, 1052 Skipped, 11h 50m 34.65s Total duration (26m 55.62s time saved) |
…n_module_has_no_path
…n_module_has_no_path
Okay, so, I kind of "lied" in my last comment. I wanted to do "the right thing" but that would've involved pinning The result is this PR which I think should bridge the gap between now and when I've undertaken the rewrite I mentioned in my previous comment. |
…n_module_has_no_path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to update the release note. Aside from that LGTM
releasenotes/notes/ci_visibility-fix-pytest-8.0.0-support-88fcb7b5144d7efa.yaml
Outdated
Show resolved
Hide resolved
…b7b5144d7efa.yaml Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
…n_module_has_no_path
…s_no_path' of github.com:DataDog/dd-trace-py into romain.komorn/CIVIS-8969/fix_civis_crash_when_module_has_no_path
…n_module_has_no_path
…n_module_has_no_path
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport-8357-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 78d5b98c58691c750cecc6954dc4bd6b452f0226
# Push it to GitHub
git push --set-upstream origin backport-8357-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport-8357-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 78d5b98c58691c750cecc6954dc4bd6b452f0226
# Push it to GitHub
git push --set-upstream origin backport-8357-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5 Then, create a pull request where the |
Addresses #8220 and fixes an issue with `pytest` `8.x` and above (brought by pytest-dev/pytest#11137 ) where `pytest.Package` objects no longer have an attached `module` attribute. This also changes the testing matrix to include version `~=8.0`, but maintains `~=7.0` as a separate testing environment. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> (cherry picked from commit 78d5b98)
Backport 78d5b98 from #8357 to 2.6. Addresses #8220 and fixes an issue with `pytest` `8.x` and above (brought by pytest-dev/pytest#11137 ) where `pytest.Package` objects no longer have an attached `module` attribute. This also changes the testing matrix to include version `~=8.0`, but maintains `~=7.0` as a separate testing environment. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Backport 78d5b98 from #8357 to 2.5. Addresses #8220 and fixes an issue with `pytest` `8.x` and above (brought by pytest-dev/pytest#11137 ) where `pytest.Package` objects no longer have an attached `module` attribute. This also changes the testing matrix to include version `~=8.0`, but maintains `~=7.0` as a separate testing environment. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Federico Mon <federico.mon@datadoghq.com>
Backport 78d5b98 from #8357 to 2.4. Addresses #8220 and fixes an issue with `pytest` `8.x` and above (brought by pytest-dev/pytest#11137 ) where `pytest.Package` objects no longer have an attached `module` attribute. This also changes the testing matrix to include version `~=8.0`, but maintains `~=7.0` as a separate testing environment. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Federico Mon <federico.mon@datadoghq.com>
Addresses #8220 and fixes an issue with
pytest
8.x
and above(brought by pytest-dev/pytest#11137 ) where
pytest.Package
objects no longer have an attachedmodule
attribute.This also changes the testing matrix to include version
~=8.0
, but maintains~=7.0
as a separate testing environment.Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist