Skip to content

chore(iast): skip mysqlsh from ast patching #13981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

avara1986
Copy link
Member

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jul 14, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_ast/iastpatch.c                                   @DataDog/asm-python

Copy link
Contributor

github-actions bot commented Jul 14, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 278 ± 3 ms.

The average import time from base is: 280 ± 3 ms.

The import time difference between this PR and base is: -2.3 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.000 ms (0.72%)
ddtrace.bootstrap.sitecustomize 1.317 ms (0.47%)
ddtrace.bootstrap.preload 1.317 ms (0.47%)
ddtrace.internal.remoteconfig.client 0.651 ms (0.23%)
ddtrace 0.683 ms (0.25%)
ddtrace.internal._unpatched 0.031 ms (0.01%)
json 0.031 ms (0.01%)
json.decoder 0.031 ms (0.01%)
re 0.031 ms (0.01%)
enum 0.031 ms (0.01%)
types 0.031 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jul 14, 2025

Benchmarks

Benchmark execution time: 2025-07-14 20:38:01

Comparing candidate commit ea1025b in PR branch avara1986/APPSEC-58305_skip_mysqlsh with baseline commit df60cba in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 341 metrics, 2 unstable metrics.

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+730.103ns; +833.597ns] or [+17.208%; +19.647%]

scenario:iastaspectsospath-ospathsplit_aspect

  • 🟥 execution_time [+434.621ns; +716.443ns] or [+8.916%; +14.698%]

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+484.306ns; +558.352ns] or [+13.188%; +15.204%]

@avara1986 avara1986 marked this pull request as ready for review July 14, 2025 20:01
@avara1986 avara1986 requested a review from a team as a code owner July 14, 2025 20:01
@avara1986 avara1986 closed this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant