-
Notifications
You must be signed in to change notification settings - Fork 440
ci: native extension hash cache #13675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 273 ± 2 ms. The average import time from base is: 276 ± 2 ms. The import time difference between this PR and base is: -2.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-17 19:21:57 Comparing candidate commit 7ea29ec in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 557 metrics, 3 unstable metrics. scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectsospath-ospathsplit_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
scenario:telemetryaddmetric-1-distribution-metric-1-times
|
6f2e103
to
51d40bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high level looks good
1318da0
to
b792156
Compare
We make the native extension cache more fine-grained by generating hashes for each single native integration that we build.
b792156
to
475f53f
Compare
b9cc62e
to
f6b4c86
Compare
9cc194d
to
0ce8fda
Compare
0ce8fda
to
74a8c35
Compare
riot -v run -s --python=$PYTHON_VERSION smoke_test | ||
touch cache_used.txt | ||
apt update && apt install -y sccache | ||
pip install riot==0.20.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can include riot in the cached venv?
We make the native extension cache more fine-grained by generating hashes for each single native integration that we build. We then store each generated artifact in the cache according to this FS structure
We implement a custom command to allow retrieving the source to target mapping from
setup.py
directly, instead of coding the same information elsewhere, which would increase the maintenance cost of the whole build process.Checklist
Reviewer Checklist