Skip to content

feat(co): add in-product enablement support #13633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Jun 10, 2025

We add support for in-product enablement to code origin for spans.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We add support for in-product enablement to code origin for spans.
@P403n1x87 P403n1x87 added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Jun 10, 2025
@P403n1x87 P403n1x87 requested review from a team as code owners June 10, 2025 10:18
@P403n1x87 P403n1x87 requested review from wantsui and erikayasuda June 10, 2025 10:18
Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/feat-co-in-product-enablement-6b70fc52d62721fa.yaml  @DataDog/apm-python
ddtrace/debugging/_products/code_origin/span.py                         @DataDog/debugger-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 277 ± 2 ms.

The average import time from base is: 277 ± 2 ms.

The import time difference between this PR and base is: -0.8 ± 0.1 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.383 ms (0.14%)
ddtrace.bootstrap.sitecustomize 0.383 ms (0.14%)
ddtrace._trace.trace_handlers 0.153 ms (0.06%)
ddtrace.contrib.trace_utils 0.085 ms (0.03%)
ddtrace.contrib.internal.trace_utils 0.085 ms (0.03%)
ddtrace.contrib.internal.trace_utils_base 0.085 ms (0.03%)
ddtrace.ext.user 0.085 ms (0.03%)
ddtrace._trace._inferred_proxy 0.068 ms (0.02%)
ddtrace.propagation.http 0.068 ms (0.02%)
ddtrace.propagation._utils 0.068 ms (0.02%)
ddtrace.contrib.internal.subprocess.constants 0.084 ms (0.03%)
ddtrace.bootstrap.preload 0.074 ms (0.03%)
ddtrace.appsec._remoteconfiguration 0.074 ms (0.03%)
ddtrace.appsec._common_module_patches 0.071 ms (0.03%)
ddtrace.appsec._asm_request_context 0.071 ms (0.03%)
ddtrace.appsec._utils 0.071 ms (0.03%)

The following import paths have shrunk:

ddtrace.auto 1.764 ms (0.64%)
ddtrace.bootstrap.sitecustomize 1.093 ms (0.40%)
ddtrace.bootstrap.preload 0.721 ms (0.26%)
ddtrace.internal.remoteconfig.client 0.559 ms (0.20%)
ddtrace.debugging._import 0.082 ms (0.03%)
ddtrace.debugging._function.discovery 0.082 ms (0.03%)
ddtrace.internal.remoteconfig.worker 0.081 ms (0.03%)
ddtrace._trace.trace_handlers 0.191 ms (0.07%)
ddtrace._trace._inferred_proxy 0.062 ms (0.02%)
ddtrace.propagation.http 0.062 ms (0.02%)
ddtrace.appsec._common_module_patches 0.180 ms (0.07%)
ddtrace.appsec._asm_request_context 0.093 ms (0.03%)
ddtrace.appsec._metrics 0.088 ms (0.03%)
ddtrace 0.671 ms (0.24%)
ddtrace.internal._unpatched 0.021 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 10, 2025

Benchmarks

Benchmark execution time: 2025-06-10 11:08:05

Comparing candidate commit 714aeb9 in PR branch feat/co-in-product-enablement with baseline commit 140c2b9 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 549 metrics, 3 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+382.236ns; +482.871ns] or [+11.851%; +14.972%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+744.645ns; +803.925ns] or [+17.249%; +18.622%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+362.718ns; +423.466ns] or [+10.524%; +12.286%]

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+340.588ns; +391.014ns] or [+9.327%; +10.708%]

@tylfin
Copy link
Contributor

tylfin commented Jun 10, 2025

I think in-product enablement should only enable entry spans so this might be blocked by #13593.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants