Skip to content

Commit 08a88b6

Browse files
authored
chore: fix cargo clippy issues with new versions of rust (#13916)
With #13902 we are getting a newer version of rust and `cargo clippy` is reporting this error: ``` error: variables can be used directly in the `format!` string --> library_config.rs:56:31 | 56 | let err_msg = format!("Failed to get configuration: {:?}", e); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-D clippy::uninlined-format-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]` help: change this to | 56 - let err_msg = format!("Failed to get configuration: {:?}", e); 56 + let err_msg = format!("Failed to get configuration: {e:?}"); | error: variables can be used directly in the `format!` string --> library_config.rs:119:27 | 119 | let err_msg = format!("Failed to store the tracer configuration: {:?}", e); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 119 - let err_msg = format!("Failed to store the tracer configuration: {:?}", e); 119 + let err_msg = format!("Failed to store the tracer configuration: {e:?}"); | error: could not compile `ddtrace-native` (lib) due to 2 previous errors ``` This change fixes this. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 4e913c9 commit 08a88b6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/native/library_config.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ impl PyConfigurator {
5353
Ok(list.into())
5454
}
5555
Err(e) => {
56-
let err_msg = format!("Failed to get configuration: {:?}", e);
56+
let err_msg = format!("Failed to get configuration: {e:?}");
5757
Err(PyException::new_err(err_msg))
5858
}
5959
}
@@ -116,7 +116,7 @@ pub fn store_metadata(data: &PyTracerMetadata) -> PyResult<PyAnonymousFileHandle
116116
match res {
117117
Ok(handle) => Ok(PyAnonymousFileHandle { internal: handle }),
118118
Err(e) => {
119-
let err_msg = format!("Failed to store the tracer configuration: {:?}", e);
119+
let err_msg = format!("Failed to store the tracer configuration: {e:?}");
120120
Err(PyException::new_err(err_msg))
121121
}
122122
}

0 commit comments

Comments
 (0)