Skip to content

Use errorMonitor symbol instead of listening to the error event #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2025

Conversation

BridgeAR
Copy link
Collaborator

@BridgeAR BridgeAR commented May 8, 2025

This is important to guarantee user code behaves as it did without
the instrumentation. So user crashes should happen as before.

Copy link

github-actions bot commented May 8, 2025

Overall package size

Self size: 9.38 MB
Deduped: 103.4 MB
No deduping: 103.92 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.05%. Comparing base (3a2ed10) to head (458e049).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...ckages/datadog-instrumentations/src/http/client.js 50.00% 1 Missing ⚠️
packages/datadog-instrumentations/src/net.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5682   +/-   ##
=======================================
  Coverage   79.04%   79.05%           
=======================================
  Files         515      515           
  Lines       23589    23590    +1     
=======================================
+ Hits        18647    18648    +1     
  Misses       4942     4942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 8, 2025

Datadog Report

Branch report: BridgeAR/safer-on-error
Commit report: f886e1e
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 985 Passed, 0 Skipped, 14m 54.77s Total Time

@pr-commenter
Copy link

pr-commenter bot commented May 8, 2025

Benchmarks

Benchmark execution time: 2025-05-18 18:49:35

Comparing candidate commit 458e049 in PR branch BridgeAR/safer-on-error with baseline commit 3a2ed10 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1268 metrics, 55 unstable metrics.

This is important to guarantee user code behaves as it did without
the instrumentation. So user crashes should happen as before.
@BridgeAR BridgeAR force-pushed the BridgeAR/safer-on-error branch from dd6a6fb to d6d080c Compare May 14, 2025 23:02
@BridgeAR BridgeAR marked this pull request as ready for review May 14, 2025 23:02
@BridgeAR BridgeAR requested review from a team as code owners May 14, 2025 23:02
@BridgeAR BridgeAR requested review from bengl and rochdev May 14, 2025 23:02
watson
watson previously approved these changes May 16, 2025
Copy link
Collaborator

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just my one nit about the TODO comment. Feel free to merge without it or add it and I'll re-approve

@watson watson merged commit 22d38aa into master May 19, 2025
487 checks passed
@watson watson deleted the BridgeAR/safer-on-error branch May 19, 2025 08:46
dd-trace-js bot pushed a commit that referenced this pull request May 19, 2025
This is important to guarantee user code behaves as it did without
the instrumentation. So user crashes should happen as before.
@dd-trace-js dd-trace-js bot mentioned this pull request May 19, 2025
dd-trace-js bot pushed a commit that referenced this pull request May 20, 2025
This is important to guarantee user code behaves as it did without
the instrumentation. So user crashes should happen as before.
@dd-trace-js dd-trace-js bot mentioned this pull request May 20, 2025
BridgeAR added a commit that referenced this pull request May 23, 2025
This is important to guarantee user code behaves as it did without
the instrumentation. So user crashes should happen as before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants