Code cleanup: Improve calculation of number of bytes in string (#5924)

watson · web-flow · commit a65d07496bc1 · 2025-06-23T13:50:01.000+02:00
diff --git a/packages/dd-trace/src/llmobs/writers/spans.js b/packages/dd-trace/src/llmobs/writers/spans.js
@@ -35,7 +35,7 @@ class LLMObsSpanWriter extends BaseWriter {
     if (shouldTruncate) {
       logger.warn(`Dropping event input/output because its size (${eventSizeBytes}) exceeds the 1MB event size limit`)
       event = this._truncateSpanEvent(event)
-      processedEventSizeBytes = Buffer.from(JSON.stringify(event)).byteLength
+      processedEventSizeBytes = Buffer.byteLength(JSON.stringify(event))
     }
 
     telemetry.recordLLMObsSpanSize(event, processedEventSizeBytes, shouldTruncate)

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ class LLMObsSpanWriter extends BaseWriter {`
`35`	`35`	`if (shouldTruncate) {`
`36`	`36`	logger.warn(`Dropping event input/output because its size (${eventSizeBytes}) exceeds the 1MB event size limit`)
`37`	`37`	`event = this._truncateSpanEvent(event)`
`38`		`- processedEventSizeBytes = Buffer.from(JSON.stringify(event)).byteLength`
	`38`	`+ processedEventSizeBytes = Buffer.byteLength(JSON.stringify(event))`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`telemetry.recordLLMObsSpanSize(event, processedEventSizeBytes, shouldTruncate)`