apparently not all tests end in .spec.js

Author: tlhunter

packages/dd-trace/test/appsec/graphq.test-utils.js

@@ -102,7 +102,7 @@ function graphqlCommonTests (config) {
     })
 
     it('Should set appsec.blocked on blocked attack', (done) => {
-      agent.use(payload => {
+      agent.assertSomeTraces(payload => {
         expect(payload[0][0].meta['appsec.blocked']).to.be.equal('true')
         done()
       })
@@ -201,7 +201,7 @@ function graphqlCommonTests (config) {
     })
 
     it('Should set appsec.blocked on blocked attack', (done) => {
-      agent.use(payload => {
+      agent.assertSomeTraces(payload => {
         expect(payload[0][0].meta['appsec.blocked']).to.be.equal('true')
         done()
       })

packages/dd-trace/test/appsec/iast/taint-tracking/sources/graphql.sources.test-utils.js

@@ -82,7 +82,7 @@ function graphqlCommonTests (config) {
     })
 
     it('Should detect COMMAND_INJECTION vulnerability with hardcoded query', (done) => {
-      agent.use(payload => {
+      agent.assertSomeTraces(payload => {
         expect(payload[0][0].meta).to.have.property('_dd.iast.json')
 
         const iastJson = JSON.parse(payload[0][0].meta['_dd.iast.json'])
@@ -94,7 +94,7 @@ function graphqlCommonTests (config) {
     })
 
     it('Should detect COMMAND_INJECTION vulnerability with query and variables', (done) => {
-      agent.use(payload => {
+      agent.assertSomeTraces(payload => {
         expect(payload[0][0].meta).to.have.property('_dd.iast.json')
 
         const iastJson = JSON.parse(payload[0][0].meta['_dd.iast.json'])

packages/dd-trace/test/appsec/rasp/utils.js

@@ -4,7 +4,7 @@ const { assert } = require('chai')
 const { getWebSpan } = require('../utils')
 
 function checkRaspExecutedAndNotThreat (agent, checkRuleEval = true) {
-  return agent.use((traces) => {
+  return agent.assertSomeTraces((traces) => {
     const span = getWebSpan(traces)
     assert.notProperty(span.meta, '_dd.appsec.json')
     assert.notProperty(span.meta_struct || {}, '_dd.stack')
@@ -15,7 +15,7 @@ function checkRaspExecutedAndNotThreat (agent, checkRuleEval = true) {
 }
 
 function checkRaspExecutedAndHasThreat (agent, ruleId, ruleEvalCount = 1) {
-  return agent.use((traces) => {
+  return agent.assertSomeTraces((traces) => {
     const span = getWebSpan(traces)
     assert.property(span.meta, '_dd.appsec.json')
     assert(span.meta['_dd.appsec.json'].includes(ruleId))

packages/dd-trace/test/plugins/agent.js

@@ -279,8 +279,8 @@ module.exports = {
   async load (pluginName, config, tracerConfig = {}) {
     tracer = require('../..')
     agent = express()
-    agent.use(bodyParser.raw({ limit: Infinity, type: 'application/msgpack' }))
-    agent.use((req, res, next) => {
+    agent.assertSomeTraces(bodyParser.raw({ limit: Infinity, type: 'application/msgpack' }))
+    agent.assertSomeTraces((req, res, next) => {
       if (req.is('application/msgpack')) {
         if (!req.body.length) return res.status(200).send()
         req.body = msgpack.decode(req.body, { useBigInt64: true })

packages/dd-trace/test/plugins/helpers.js

@@ -15,7 +15,7 @@ function resolveNaming (namingSchema) {
 }
 
 function expectSomeSpan (agent, expected, timeout) {
-  return agent.use(traces => {
+  return agent.assertSomeTraces(traces => {
     const scoredErrors = []
     for (const trace of traces) {
       for (const span of trace) {