Skip to content

Commit 62d20bb

Browse files
authored
test: fix race condition in kinesis tests by swallowing irrelevant errors (#6691)
1 parent 43d8bc7 commit 62d20bb

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

packages/datadog-plugin-aws-sdk/test/kinesis.spec.js

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ describe('Kinesis', function () {
162162
expect(span.meta).to.have.property('streamname', streamName)
163163
}).then(done, done)
164164

165-
helpers.putTestRecord(kinesis, streamName, helpers.dataBuffer, e => e && done(e))
165+
helpers.putTestRecord(kinesis, streamName, helpers.dataBuffer, () => {})
166166
})
167167

168168
describe('Disabled', () => {
@@ -260,9 +260,7 @@ describe('Kinesis', function () {
260260
helpers.putTestRecord(kinesis, streamNameDSM, helpers.dataBuffer, (err, data) => {
261261
if (err) return done(err)
262262

263-
helpers.getTestData(kinesis, streamNameDSM, data, (err) => {
264-
if (err) return done(err)
265-
})
263+
helpers.getTestData(kinesis, streamNameDSM, data, () => {})
266264
})
267265
})
268266

@@ -280,9 +278,7 @@ describe('Kinesis', function () {
280278
})
281279
}).then(done, done)
282280

283-
helpers.putTestRecord(kinesis, streamNameDSM, helpers.dataBuffer, (err, data) => {
284-
if (err) return done(err)
285-
})
281+
helpers.putTestRecord(kinesis, streamNameDSM, helpers.dataBuffer, () => {})
286282
})
287283

288284
it('emits DSM stats to the agent during Kinesis putRecord', done => {
@@ -300,9 +296,7 @@ describe('Kinesis', function () {
300296
expect(agent.dsmStatsExist(agent, expectedProducerHash)).to.equal(true)
301297
}, { timeoutMs: 10000 }).then(done, done)
302298

303-
helpers.putTestRecord(kinesis, streamNameDSM, helpers.dataBuffer, (err, data) => {
304-
if (err) return done(err)
305-
})
299+
helpers.putTestRecord(kinesis, streamNameDSM, helpers.dataBuffer, () => {})
306300
})
307301

308302
it('emits DSM stats to the agent during Kinesis getRecord', done => {
@@ -323,9 +317,7 @@ describe('Kinesis', function () {
323317
helpers.putTestRecord(kinesis, streamNameDSM, helpers.dataBuffer, (err, data) => {
324318
if (err) return done(err)
325319

326-
helpers.getTestData(kinesis, streamNameDSM, data, (err) => {
327-
if (err) return done(err)
328-
})
320+
helpers.getTestData(kinesis, streamNameDSM, data, () => {})
329321
})
330322
})
331323

@@ -349,9 +341,7 @@ describe('Kinesis', function () {
349341
if (err) return done(err)
350342

351343
agent.reload('aws-sdk', { kinesis: { dsmEnabled: true } }, { dsmEnabled: true })
352-
helpers.getTestData(kinesis, streamNameDSM, data, (err) => {
353-
if (err) return done(err)
354-
})
344+
helpers.getTestData(kinesis, streamNameDSM, data, () => {})
355345
})
356346
})
357347

0 commit comments

Comments
 (0)