fix(ws): add missing ctx.span guard in bindAsyncStart and asyncStart (#8002)

Author: snoopy55619819

packages/datadog-plugin-ws/src/close.js

@@ -57,11 +57,13 @@ class WSClosePlugin extends TracingPlugin {
   }
 
   bindAsyncStart (ctx) {
+    if (!ctx.span) return ctx.parentStore
     if (!ctx.isPeerClose) ctx.span.finish()
     return ctx.parentStore
   }
 
   asyncStart (ctx) {
+    if (!ctx.span) return
     ctx.span.finish()
   }
 

packages/datadog-plugin-ws/src/producer.js

@@ -46,11 +46,13 @@ class WSProducerPlugin extends TracingPlugin {
   }
 
   bindAsyncStart (ctx) {
+    if (!ctx.span) return ctx.parentStore
     ctx.span.finish()
     return ctx.parentStore
   }
 
   asyncStart (ctx) {
+    if (!ctx.span) return
     ctx.span.finish()
   }
 

packages/datadog-plugin-ws/src/receiver.js

@@ -62,6 +62,7 @@ class WSReceiverPlugin extends TracingPlugin {
   }
 
   asyncStart (ctx) {
+    if (!ctx.span) return
     ctx.span.finish()
   }
 

packages/datadog-plugin-ws/test/index.spec.js

@@ -31,6 +31,27 @@ describe('Plugin', () => {
           WebSocket = require(`../../../versions/ws@${version}`).get()
         })
 
+        it('should not crash when sending on a socket without spanContext', async () => {
+          const server = new WebSocket.Server({ port: 16015 })
+          const connectionPromise = once(server, 'connection')
+
+          const socket = new WebSocket('ws://localhost:16015')
+          const [serverSocket] = await connectionPromise
+          await once(socket, 'open')
+
+          assert.strictEqual(socket.spanContext, undefined)
+
+          const messagePromise = once(serverSocket, 'message')
+          await new Promise((resolve, reject) => {
+            socket.send('test message', {}, (err) => err ? reject(err) : resolve())
+          })
+          await messagePromise
+
+          socket.close()
+          await once(socket, 'close')
+          server.close()
+        })
+
         it('should emit original error in case close is called before connection is established', async () => {
           const socket = new WebSocket('wss://localhost:12345')