-
Notifications
You must be signed in to change notification settings - Fork 316
[WIP] openai-java instrumentation #9959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…stead of forcing it
…d "streamed async request completion test with withRawResponse"
Call decorateWithResponse from the wrappers
Rename span resources to be aligned with trace-py Add http.client resource assertion
Test case renaming
Reorder tests by synch, async
Fix Embeddings fixture for the latestDepTest when base64
|
🎯 Code Coverage 🔗 Commit SHA: 637f8e5 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 6 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~637f8e5d72, baseline=1.56.0-SNAPSHOT~b436de808f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1095305
Total [baseline] (10.714 s) : 0, 10714023
Agent [candidate] (1.114 s) : 0, 1114081
Total [candidate] (10.827 s) : 0, 10826965
section appsec
Agent [baseline] (1.278 s) : 0, 1277687
Total [baseline] (11.052 s) : 0, 11051692
Agent [candidate] (1.285 s) : 0, 1284597
Total [candidate] (11.11 s) : 0, 11109918
section iast
Agent [baseline] (1.239 s) : 0, 1239016
Total [baseline] (11.183 s) : 0, 11183321
Agent [candidate] (1.238 s) : 0, 1238168
Total [candidate] (11.143 s) : 0, 11143263
section profiling
Agent [baseline] (1.226 s) : 0, 1225622
Total [baseline] (11.094 s) : 0, 11093990
Agent [candidate] (1.237 s) : 0, 1236864
Total [candidate] (11.146 s) : 0, 11145632
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~637f8e5d72, baseline=1.56.0-SNAPSHOT~b436de808f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (703.428 ms) : 0, 703428
BytebuddyAgent [candidate] (717.426 ms) : 0, 717426
GlobalTracer [baseline] (247.614 ms) : 0, 247614
GlobalTracer [candidate] (251.099 ms) : 0, 251099
AppSec [baseline] (31.988 ms) : 0, 31988
AppSec [candidate] (32.495 ms) : 0, 32495
Debugger [baseline] (63.705 ms) : 0, 63705
Debugger [candidate] (63.924 ms) : 0, 63924
Remote Config [baseline] (639.327 µs) : 0, 639
Remote Config [candidate] (628.243 µs) : 0, 628
Telemetry [baseline] (8.128 ms) : 0, 8128
Telemetry [candidate] (8.25 ms) : 0, 8250
Flare Poller [baseline] (3.603 ms) : 0, 3603
Flare Poller [candidate] (3.729 ms) : 0, 3729
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (729.414 ms) : 0, 729414
BytebuddyAgent [candidate] (733.887 ms) : 0, 733887
GlobalTracer [baseline] (239.858 ms) : 0, 239858
GlobalTracer [candidate] (241.346 ms) : 0, 241346
IAST [baseline] (24.862 ms) : 0, 24862
IAST [candidate] (24.879 ms) : 0, 24879
AppSec [baseline] (173.635 ms) : 0, 173635
AppSec [candidate] (173.757 ms) : 0, 173757
Debugger [baseline] (60.807 ms) : 0, 60807
Debugger [candidate] (61.449 ms) : 0, 61449
Remote Config [baseline] (729.491 µs) : 0, 729
Remote Config [candidate] (675.551 µs) : 0, 676
Telemetry [baseline] (8.243 ms) : 0, 8243
Telemetry [candidate] (8.257 ms) : 0, 8257
Flare Poller [baseline] (3.767 ms) : 0, 3767
Flare Poller [candidate] (3.977 ms) : 0, 3977
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (829.91 ms) : 0, 829910
BytebuddyAgent [candidate] (832.526 ms) : 0, 832526
GlobalTracer [baseline] (238.294 ms) : 0, 238294
GlobalTracer [candidate] (237.133 ms) : 0, 237133
IAST [baseline] (31.752 ms) : 0, 31752
IAST [candidate] (33.884 ms) : 0, 33884
AppSec [baseline] (29.646 ms) : 0, 29646
AppSec [candidate] (26.519 ms) : 0, 26519
Debugger [baseline] (61.393 ms) : 0, 61393
Debugger [candidate] (60.147 ms) : 0, 60147
Remote Config [baseline] (565.218 µs) : 0, 565
Remote Config [candidate] (533.451 µs) : 0, 533
Telemetry [baseline] (7.679 ms) : 0, 7679
Telemetry [candidate] (7.658 ms) : 0, 7658
Flare Poller [baseline] (3.511 ms) : 0, 3511
Flare Poller [candidate] (3.475 ms) : 0, 3475
section profiling
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (728.026 ms) : 0, 728026
BytebuddyAgent [candidate] (737.715 ms) : 0, 737715
GlobalTracer [baseline] (221.654 ms) : 0, 221654
GlobalTracer [candidate] (223.791 ms) : 0, 223791
AppSec [baseline] (32.184 ms) : 0, 32184
AppSec [candidate] (32.356 ms) : 0, 32356
Debugger [baseline] (62.816 ms) : 0, 62816
Debugger [candidate] (62.564 ms) : 0, 62564
Remote Config [baseline] (654.481 µs) : 0, 654
Remote Config [candidate] (649.419 µs) : 0, 649
Telemetry [baseline] (7.965 ms) : 0, 7965
Telemetry [candidate] (7.925 ms) : 0, 7925
Flare Poller [baseline] (3.736 ms) : 0, 3736
Flare Poller [candidate] (3.832 ms) : 0, 3832
ProfilingAgent [baseline] (97.613 ms) : 0, 97613
ProfilingAgent [candidate] (96.537 ms) : 0, 96537
Profiling [baseline] (98.202 ms) : 0, 98202
Profiling [candidate] (97.138 ms) : 0, 97138
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~637f8e5d72, baseline=1.56.0-SNAPSHOT~b436de808f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1098980
Total [baseline] (8.817 s) : 0, 8816947
Agent [candidate] (1.099 s) : 0, 1099316
Total [candidate] (8.868 s) : 0, 8868318
section iast
Agent [baseline] (1.237 s) : 0, 1236672
Total [baseline] (9.512 s) : 0, 9511774
Agent [candidate] (1.239 s) : 0, 1238755
Total [candidate] (9.54 s) : 0, 9539906
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~637f8e5d72, baseline=1.56.0-SNAPSHOT~b436de808f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (705.716 ms) : 0, 705716
BytebuddyAgent [candidate] (708.408 ms) : 0, 708408
GlobalTracer [baseline] (248.385 ms) : 0, 248385
GlobalTracer [candidate] (247.987 ms) : 0, 247987
AppSec [baseline] (32.519 ms) : 0, 32519
AppSec [candidate] (32.119 ms) : 0, 32119
Debugger [baseline] (63.568 ms) : 0, 63568
Debugger [candidate] (62.339 ms) : 0, 62339
Remote Config [baseline] (633.666 µs) : 0, 634
Remote Config [candidate] (598.124 µs) : 0, 598
Telemetry [baseline] (8.236 ms) : 0, 8236
Telemetry [candidate] (8.026 ms) : 0, 8026
Flare Poller [baseline] (3.699 ms) : 0, 3699
Flare Poller [candidate] (3.603 ms) : 0, 3603
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (829.316 ms) : 0, 829316
BytebuddyAgent [candidate] (832.588 ms) : 0, 832588
GlobalTracer [baseline] (237.904 ms) : 0, 237904
GlobalTracer [candidate] (237.117 ms) : 0, 237117
AppSec [baseline] (32.278 ms) : 0, 32278
AppSec [candidate] (32.472 ms) : 0, 32472
Debugger [baseline] (59.982 ms) : 0, 59982
Debugger [candidate] (60.225 ms) : 0, 60225
Remote Config [baseline] (541.924 µs) : 0, 542
Remote Config [candidate] (551.129 µs) : 0, 551
Telemetry [baseline] (7.673 ms) : 0, 7673
Telemetry [candidate] (7.726 ms) : 0, 7726
Flare Poller [baseline] (3.444 ms) : 0, 3444
Flare Poller [candidate] (3.437 ms) : 0, 3437
IAST [baseline] (29.165 ms) : 0, 29165
IAST [candidate] (28.23 ms) : 0, 28230
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~637f8e5d72, baseline=1.56.0-SNAPSHOT~b436de808f
dateFormat X
axisFormat %s
section baseline
no_agent (1.197 ms) : 1186, 1209
. : milestone, 1197,
iast (3.503 ms) : 3419, 3586
. : milestone, 3503,
iast_FULL (5.993 ms) : 5932, 6054
. : milestone, 5993,
iast_GLOBAL (3.679 ms) : 3624, 3733
. : milestone, 3679,
profiling (2.113 ms) : 2093, 2133
. : milestone, 2113,
tracing (1.824 ms) : 1810, 1839
. : milestone, 1824,
section candidate
no_agent (1.188 ms) : 1176, 1199
. : milestone, 1188,
iast (3.354 ms) : 3223, 3485
. : milestone, 3354,
iast_FULL (5.981 ms) : 5920, 6042
. : milestone, 5981,
iast_GLOBAL (3.731 ms) : 3676, 3786
. : milestone, 3731,
profiling (2.335 ms) : 2312, 2358
. : milestone, 2335,
tracing (1.783 ms) : 1768, 1797
. : milestone, 1783,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~637f8e5d72, baseline=1.56.0-SNAPSHOT~b436de808f
dateFormat X
axisFormat %s
section baseline
no_agent (17.099 ms) : 16925, 17274
. : milestone, 17099,
appsec (18.816 ms) : 18626, 19006
. : milestone, 18816,
code_origins (17.739 ms) : 17563, 17916
. : milestone, 17739,
iast (17.507 ms) : 17332, 17682
. : milestone, 17507,
profiling (18.42 ms) : 18238, 18602
. : milestone, 18420,
tracing (18.039 ms) : 17859, 18219
. : milestone, 18039,
section candidate
no_agent (17.9 ms) : 17720, 18079
. : milestone, 17900,
appsec (18.165 ms) : 17981, 18349
. : milestone, 18165,
code_origins (18.214 ms) : 18032, 18396
. : milestone, 18214,
iast (17.616 ms) : 17443, 17789
. : milestone, 17616,
profiling (18.357 ms) : 18172, 18542
. : milestone, 18357,
tracing (17.748 ms) : 17571, 17925
. : milestone, 17748,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~637f8e5d72, baseline=1.56.0-SNAPSHOT~b436de808f
dateFormat X
axisFormat %s
section baseline
no_agent (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
appsec (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
iast (18.61 s) : 18610000, 18610000
. : milestone, 18610000,
iast_GLOBAL (17.903 s) : 17903000, 17903000
. : milestone, 17903000,
profiling (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
tracing (14.49 s) : 14490000, 14490000
. : milestone, 14490000,
section candidate
no_agent (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
appsec (14.793 s) : 14793000, 14793000
. : milestone, 14793000,
iast (18.673 s) : 18673000, 18673000
. : milestone, 18673000,
iast_GLOBAL (17.794 s) : 17794000, 17794000
. : milestone, 17794000,
profiling (14.857 s) : 14857000, 14857000
. : milestone, 14857000,
tracing (14.685 s) : 14685000, 14685000
. : milestone, 14685000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~637f8e5d72, baseline=1.56.0-SNAPSHOT~b436de808f
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.466 ms) : 2415, 2517
. : milestone, 2466,
iast (2.216 ms) : 2152, 2280
. : milestone, 2216,
iast_GLOBAL (2.256 ms) : 2192, 2320
. : milestone, 2256,
profiling (2.075 ms) : 2022, 2128
. : milestone, 2075,
tracing (2.032 ms) : 1982, 2081
. : milestone, 2032,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.628 ms) : 3414, 3843
. : milestone, 3628,
iast (2.214 ms) : 2150, 2278
. : milestone, 2214,
iast_GLOBAL (2.261 ms) : 2197, 2326
. : milestone, 2261,
profiling (2.084 ms) : 2030, 2138
. : milestone, 2084,
tracing (2.024 ms) : 1975, 2074
. : milestone, 2024,
|
…Support openai-java v3+
test_openai.py::TestOpenAiApm PASS
test_openai.py::TestOpenAiApm PASS
What Does This Do
The openai-java 1.0+ instrumentation for completions, chat completions, embeddings, and responses.
Currently it only creates APM spans:
TBD: llmobs specifics
TBD: telemetry
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]