-
Notifications
You must be signed in to change notification settings - Fork 305
Replace System.currentTimeMillis
by nanoTime
#8989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~f18dbbc5a8, baseline=1.50.0-SNAPSHOT~88aa5b2174
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1032377
Total [baseline] (8.568 s) : 0, 8568383
Agent [candidate] (1.025 s) : 0, 1024898
Total [candidate] (8.541 s) : 0, 8540526
section iast
Agent [baseline] (1.153 s) : 0, 1152760
Total [baseline] (9.222 s) : 0, 9222492
Agent [candidate] (1.154 s) : 0, 1154376
Total [candidate] (9.25 s) : 0, 9250026
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.166 s) : 0, 1166402
Total [baseline] (9.173 s) : 0, 9173441
Agent [candidate] (1.158 s) : 0, 1158436
Total [candidate] (9.197 s) : 0, 9197225
section iast_TELEMETRY_OFF
Agent [baseline] (1.148 s) : 0, 1147559
Total [baseline] (9.216 s) : 0, 9215562
Agent [candidate] (1.149 s) : 0, 1148782
Total [candidate] (9.217 s) : 0, 9217048
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~f18dbbc5a8, baseline=1.50.0-SNAPSHOT~88aa5b2174
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.175 ms) : 0, 687175
BytebuddyAgent [candidate] (682.275 ms) : 0, 682275
GlobalTracer [baseline] (242.136 ms) : 0, 242136
GlobalTracer [candidate] (240.006 ms) : 0, 240006
AppSec [baseline] (59.165 ms) : 0, 59165
AppSec [candidate] (58.272 ms) : 0, 58272
Debugger [baseline] (6.244 ms) : 0, 6244
Debugger [candidate] (6.195 ms) : 0, 6195
Remote Config [baseline] (762.677 µs) : 0, 763
Remote Config [candidate] (754.951 µs) : 0, 755
Telemetry [baseline] (13.178 ms) : 0, 13178
Telemetry [candidate] (13.778 ms) : 0, 13778
section iast
BytebuddyAgent [baseline] (801.567 ms) : 0, 801567
BytebuddyAgent [candidate] (803.229 ms) : 0, 803229
GlobalTracer [baseline] (231.113 ms) : 0, 231113
GlobalTracer [candidate] (230.474 ms) : 0, 230474
AppSec [baseline] (55.9 ms) : 0, 55900
AppSec [candidate] (56.334 ms) : 0, 56334
Debugger [baseline] (6.021 ms) : 0, 6021
Debugger [candidate] (5.973 ms) : 0, 5973
Remote Config [baseline] (600.706 µs) : 0, 601
Remote Config [candidate] (658.191 µs) : 0, 658
Telemetry [baseline] (7.936 ms) : 0, 7936
Telemetry [candidate] (7.9 ms) : 0, 7900
IAST [baseline] (26.004 ms) : 0, 26004
IAST [candidate] (26.24 ms) : 0, 26240
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.258 ms) : 0, 812258
BytebuddyAgent [candidate] (806.021 ms) : 0, 806021
GlobalTracer [baseline] (232.839 ms) : 0, 232839
GlobalTracer [candidate] (231.305 ms) : 0, 231305
AppSec [baseline] (57.346 ms) : 0, 57346
AppSec [candidate] (56.609 ms) : 0, 56609
Debugger [baseline] (5.917 ms) : 0, 5917
Debugger [candidate] (5.948 ms) : 0, 5948
Remote Config [baseline] (591.598 µs) : 0, 592
Remote Config [candidate] (590.873 µs) : 0, 591
Telemetry [baseline] (7.88 ms) : 0, 7880
Telemetry [candidate] (7.906 ms) : 0, 7906
IAST [baseline] (25.827 ms) : 0, 25827
IAST [candidate] (26.476 ms) : 0, 26476
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.673 ms) : 0, 797673
BytebuddyAgent [candidate] (798.638 ms) : 0, 798638
GlobalTracer [baseline] (230.088 ms) : 0, 230088
GlobalTracer [candidate] (230.905 ms) : 0, 230905
AppSec [baseline] (54.134 ms) : 0, 54134
AppSec [candidate] (51.997 ms) : 0, 51997
Debugger [baseline] (5.978 ms) : 0, 5978
Debugger [candidate] (5.954 ms) : 0, 5954
Remote Config [baseline] (621.061 µs) : 0, 621
Remote Config [candidate] (598.899 µs) : 0, 599
Telemetry [baseline] (7.825 ms) : 0, 7825
Telemetry [candidate] (7.929 ms) : 0, 7929
IAST [baseline] (26.965 ms) : 0, 26965
IAST [candidate] (28.598 ms) : 0, 28598
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~f18dbbc5a8, baseline=1.50.0-SNAPSHOT~88aa5b2174
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025856
Total [baseline] (10.422 s) : 0, 10421515
Agent [candidate] (1.032 s) : 0, 1031849
Total [candidate] (10.475 s) : 0, 10474535
section appsec
Agent [baseline] (1.176 s) : 0, 1176301
Total [baseline] (10.657 s) : 0, 10656573
Agent [candidate] (1.173 s) : 0, 1173477
Total [candidate] (10.633 s) : 0, 10633399
section iast
Agent [baseline] (1.157 s) : 0, 1156539
Total [baseline] (10.805 s) : 0, 10805423
Agent [candidate] (1.153 s) : 0, 1152848
Total [candidate] (10.807 s) : 0, 10806984
section profiling
Agent [baseline] (1.293 s) : 0, 1292599
Total [baseline] (11.071 s) : 0, 11071403
Agent [candidate] (1.289 s) : 0, 1289257
Total [candidate] (10.979 s) : 0, 10978558
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~f18dbbc5a8, baseline=1.50.0-SNAPSHOT~88aa5b2174
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.216 ms) : 0, 682216
BytebuddyAgent [candidate] (687.093 ms) : 0, 687093
GlobalTracer [baseline] (240.118 ms) : 0, 240118
GlobalTracer [candidate] (241.117 ms) : 0, 241117
AppSec [baseline] (59.356 ms) : 0, 59356
AppSec [candidate] (59.783 ms) : 0, 59783
Debugger [baseline] (6.168 ms) : 0, 6168
Debugger [candidate] (6.259 ms) : 0, 6259
Remote Config [baseline] (751.286 µs) : 0, 751
Remote Config [candidate] (761.549 µs) : 0, 762
Telemetry [baseline] (13.66 ms) : 0, 13660
Telemetry [candidate] (13.025 ms) : 0, 13025
section appsec
BytebuddyAgent [baseline] (703.984 ms) : 0, 703984
BytebuddyAgent [candidate] (702.897 ms) : 0, 702897
GlobalTracer [baseline] (234.392 ms) : 0, 234392
GlobalTracer [candidate] (233.475 ms) : 0, 233475
AppSec [baseline] (178.923 ms) : 0, 178923
AppSec [candidate] (178.112 ms) : 0, 178112
Debugger [baseline] (5.832 ms) : 0, 5832
Debugger [candidate] (5.854 ms) : 0, 5854
Remote Config [baseline] (615.648 µs) : 0, 616
Remote Config [candidate] (612.781 µs) : 0, 613
Telemetry [baseline] (7.243 ms) : 0, 7243
Telemetry [candidate] (7.224 ms) : 0, 7224
IAST [baseline] (21.785 ms) : 0, 21785
IAST [candidate] (21.833 ms) : 0, 21833
section iast
BytebuddyAgent [baseline] (804.934 ms) : 0, 804934
BytebuddyAgent [candidate] (802.466 ms) : 0, 802466
GlobalTracer [baseline] (231.097 ms) : 0, 231097
GlobalTracer [candidate] (230.552 ms) : 0, 230552
AppSec [baseline] (53.962 ms) : 0, 53962
AppSec [candidate] (53.585 ms) : 0, 53585
Debugger [baseline] (5.977 ms) : 0, 5977
Debugger [candidate] (5.927 ms) : 0, 5927
Remote Config [baseline] (584.402 µs) : 0, 584
Remote Config [candidate] (595.348 µs) : 0, 595
Telemetry [baseline] (7.954 ms) : 0, 7954
Telemetry [candidate] (7.905 ms) : 0, 7905
IAST [baseline] (27.715 ms) : 0, 27715
IAST [candidate] (28.139 ms) : 0, 28139
section profiling
ProfilingAgent [baseline] (109.429 ms) : 0, 109429
ProfilingAgent [candidate] (109.124 ms) : 0, 109124
BytebuddyAgent [baseline] (685.203 ms) : 0, 685203
BytebuddyAgent [candidate] (684.405 ms) : 0, 684405
GlobalTracer [baseline] (365.28 ms) : 0, 365280
GlobalTracer [candidate] (364.118 ms) : 0, 364118
AppSec [baseline] (65.646 ms) : 0, 65646
AppSec [candidate] (65.168 ms) : 0, 65168
Debugger [baseline] (6.37 ms) : 0, 6370
Debugger [candidate] (6.256 ms) : 0, 6256
Remote Config [baseline] (668.665 µs) : 0, 669
Remote Config [candidate] (670.854 µs) : 0, 671
Telemetry [baseline] (8.429 ms) : 0, 8429
Telemetry [candidate] (8.268 ms) : 0, 8268
Profiling [baseline] (109.454 ms) : 0, 109454
Profiling [candidate] (109.15 ms) : 0, 109150
LoadRequest duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~f18dbbc5a8, baseline=1.50.0-SNAPSHOT~88aa5b2174
dateFormat X
axisFormat %s
section baseline
no_agent (379.708 µs) : 360, 400
. : milestone, 380,
iast (521.746 µs) : 499, 545
. : milestone, 522,
iast_FULL (745.708 µs) : 722, 769
. : milestone, 746,
iast_GLOBAL (579.27 µs) : 556, 603
. : milestone, 579,
iast_HARDCODED_SECRET_DISABLED (519.378 µs) : 496, 543
. : milestone, 519,
iast_INACTIVE (471.663 µs) : 449, 495
. : milestone, 472,
iast_TELEMETRY_OFF (522.221 µs) : 501, 544
. : milestone, 522,
tracing (460.589 µs) : 439, 483
. : milestone, 461,
section candidate
no_agent (386.416 µs) : 366, 407
. : milestone, 386,
iast (537.963 µs) : 514, 562
. : milestone, 538,
iast_FULL (753.88 µs) : 730, 777
. : milestone, 754,
iast_GLOBAL (584.594 µs) : 561, 608
. : milestone, 585,
iast_HARDCODED_SECRET_DISABLED (536.208 µs) : 513, 560
. : milestone, 536,
iast_INACTIVE (470.992 µs) : 448, 494
. : milestone, 471,
iast_TELEMETRY_OFF (514.599 µs) : 493, 537
. : milestone, 515,
tracing (467.62 µs) : 445, 490
. : milestone, 468,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~f18dbbc5a8, baseline=1.50.0-SNAPSHOT~88aa5b2174
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (2.411 ms) : 2363, 2460
. : milestone, 2411,
iast (2.195 ms) : 2133, 2256
. : milestone, 2195,
iast_GLOBAL (2.224 ms) : 2163, 2286
. : milestone, 2224,
profiling (2.046 ms) : 1995, 2096
. : milestone, 2046,
tracing (2.011 ms) : 1963, 2058
. : milestone, 2011,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.416 ms) : 2367, 2466
. : milestone, 2416,
iast (2.2 ms) : 2138, 2261
. : milestone, 2200,
iast_GLOBAL (2.239 ms) : 2178, 2301
. : milestone, 2239,
profiling (2.041 ms) : 1991, 2090
. : milestone, 2041,
tracing (2.012 ms) : 1965, 2059
. : milestone, 2012,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~f18dbbc5a8, baseline=1.50.0-SNAPSHOT~88aa5b2174
dateFormat X
axisFormat %s
section baseline
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (14.732 s) : 14732000, 14732000
. : milestone, 14732000,
iast (18.843 s) : 18843000, 18843000
. : milestone, 18843000,
iast_GLOBAL (17.919 s) : 17919000, 17919000
. : milestone, 17919000,
profiling (15.181 s) : 15181000, 15181000
. : milestone, 15181000,
tracing (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
section candidate
no_agent (15.314 s) : 15314000, 15314000
. : milestone, 15314000,
appsec (15.007 s) : 15007000, 15007000
. : milestone, 15007000,
iast (19.123 s) : 19123000, 19123000
. : milestone, 19123000,
iast_GLOBAL (18.013 s) : 18013000, 18013000
. : milestone, 18013000,
profiling (15.272 s) : 15272000, 15272000
. : milestone, 15272000,
tracing (15.056 s) : 15056000, 15056000
. : milestone, 15056000,
|
System.currentTimeMillis
by nanoTime
System.currentTimeMillis
by nanoTime
PerfectSlayer
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
System.nanoTime
is a better fit for time measurement.Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]