-
Notifications
You must be signed in to change notification settings - Fork 303
Add zstd scenario to profile uploading tests #8869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…onfig.java Co-authored-by: Jaroslav Bachorik <jaroslav.bachorik@datadoghq.com>
…m:DataDog/dd-trace-java into mattalp/enable-zstd-profiling-compression
…m:DataDog/dd-trace-java into mattalp/enable-zstd-profiling-compression
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 53 metrics, 14 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~6783698498, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019148
Total [baseline] (10.44 s) : 0, 10439534
Agent [candidate] (1.02 s) : 0, 1020231
Total [candidate] (10.469 s) : 0, 10469247
section appsec
Agent [baseline] (1.161 s) : 0, 1161075
Total [baseline] (10.654 s) : 0, 10654253
Agent [candidate] (1.166 s) : 0, 1165529
Total [candidate] (10.74 s) : 0, 10739759
section iast
Agent [baseline] (1.149 s) : 0, 1148814
Total [baseline] (10.868 s) : 0, 10867660
Agent [candidate] (1.157 s) : 0, 1156763
Total [candidate] (10.928 s) : 0, 10928182
section profiling
Agent [baseline] (1.287 s) : 0, 1286527
Total [baseline] (10.94 s) : 0, 10939921
Agent [candidate] (1.266 s) : 0, 1266429
Total [candidate] (10.872 s) : 0, 10872373
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~6783698498, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.616 ms) : 0, 683616
BytebuddyAgent [candidate] (683.437 ms) : 0, 683437
GlobalTracer [baseline] (240.069 ms) : 0, 240069
GlobalTracer [candidate] (240.606 ms) : 0, 240606
AppSec [baseline] (54.828 ms) : 0, 54828
AppSec [candidate] (54.286 ms) : 0, 54286
Debugger [baseline] (8.217 ms) : 0, 8217
Debugger [candidate] (8.454 ms) : 0, 8454
Remote Config [baseline] (679.98 µs) : 0, 680
Remote Config [candidate] (713.559 µs) : 0, 714
Telemetry [baseline] (8.243 ms) : 0, 8243
Telemetry [candidate] (9.094 ms) : 0, 9094
section appsec
BytebuddyAgent [baseline] (700.347 ms) : 0, 700347
BytebuddyAgent [candidate] (703.398 ms) : 0, 703398
GlobalTracer [baseline] (236.516 ms) : 0, 236516
GlobalTracer [candidate] (237.522 ms) : 0, 237522
AppSec [baseline] (175.166 ms) : 0, 175166
AppSec [candidate] (175.332 ms) : 0, 175332
Debugger [baseline] (5.929 ms) : 0, 5929
Debugger [candidate] (5.948 ms) : 0, 5948
Remote Config [baseline] (622.849 µs) : 0, 623
Remote Config [candidate] (620.363 µs) : 0, 620
Telemetry [baseline] (8.144 ms) : 0, 8144
Telemetry [candidate] (8.207 ms) : 0, 8207
IAST [baseline] (21.746 ms) : 0, 21746
IAST [candidate] (21.881 ms) : 0, 21881
section iast
BytebuddyAgent [baseline] (802.247 ms) : 0, 802247
BytebuddyAgent [candidate] (807.817 ms) : 0, 807817
GlobalTracer [baseline] (230.584 ms) : 0, 230584
GlobalTracer [candidate] (232.207 ms) : 0, 232207
AppSec [baseline] (48.494 ms) : 0, 48494
AppSec [candidate] (49.656 ms) : 0, 49656
Debugger [baseline] (5.91 ms) : 0, 5910
Debugger [candidate] (5.924 ms) : 0, 5924
Remote Config [baseline] (601.197 µs) : 0, 601
Remote Config [candidate] (599.234 µs) : 0, 599
Telemetry [baseline] (7.953 ms) : 0, 7953
Telemetry [candidate] (7.919 ms) : 0, 7919
IAST [baseline] (28.86 ms) : 0, 28860
IAST [candidate] (29.149 ms) : 0, 29149
section profiling
BytebuddyAgent [baseline] (675.966 ms) : 0, 675966
BytebuddyAgent [candidate] (675.236 ms) : 0, 675236
GlobalTracer [baseline] (379.489 ms) : 0, 379489
GlobalTracer [candidate] (360.14 ms) : 0, 360140
AppSec [baseline] (54.667 ms) : 0, 54667
AppSec [candidate] (61.506 ms) : 0, 61506
Debugger [baseline] (6.149 ms) : 0, 6149
Debugger [candidate] (6.315 ms) : 0, 6315
Remote Config [baseline] (665.209 µs) : 0, 665
Remote Config [candidate] (651.015 µs) : 0, 651
Telemetry [baseline] (8.111 ms) : 0, 8111
Telemetry [candidate] (8.184 ms) : 0, 8184
ProfilingAgent [baseline] (110.568 ms) : 0, 110568
ProfilingAgent [candidate] (103.459 ms) : 0, 103459
Profiling [baseline] (110.593 ms) : 0, 110593
Profiling [candidate] (103.483 ms) : 0, 103483
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~6783698498, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1025448
Total [baseline] (8.629 s) : 0, 8629481
Agent [candidate] (1.019 s) : 0, 1019279
Total [candidate] (8.665 s) : 0, 8665393
section iast
Agent [baseline] (1.155 s) : 0, 1155496
Total [baseline] (9.232 s) : 0, 9232035
Agent [candidate] (1.157 s) : 0, 1156610
Total [candidate] (9.234 s) : 0, 9234042
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.152 s) : 0, 1151767
Total [baseline] (9.194 s) : 0, 9193846
Agent [candidate] (1.157 s) : 0, 1156646
Total [candidate] (9.184 s) : 0, 9183678
section iast_TELEMETRY_OFF
Agent [baseline] (1.151 s) : 0, 1150591
Total [baseline] (9.223 s) : 0, 9223019
Agent [candidate] (1.144 s) : 0, 1144164
Total [candidate] (9.206 s) : 0, 9205734
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~6783698498, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.565 ms) : 0, 685565
BytebuddyAgent [candidate] (681.728 ms) : 0, 681728
GlobalTracer [baseline] (240.622 ms) : 0, 240622
GlobalTracer [candidate] (239.549 ms) : 0, 239549
AppSec [baseline] (56.137 ms) : 0, 56137
AppSec [candidate] (55.078 ms) : 0, 55078
Debugger [baseline] (9.007 ms) : 0, 9007
Debugger [candidate] (9.83 ms) : 0, 9830
Remote Config [baseline] (697.591 µs) : 0, 698
Remote Config [candidate] (691.713 µs) : 0, 692
Telemetry [baseline] (9.765 ms) : 0, 9765
Telemetry [candidate] (8.888 ms) : 0, 8888
section iast
BytebuddyAgent [baseline] (807.624 ms) : 0, 807624
BytebuddyAgent [candidate] (807.621 ms) : 0, 807621
GlobalTracer [baseline] (231.277 ms) : 0, 231277
GlobalTracer [candidate] (231.913 ms) : 0, 231913
IAST [baseline] (29.329 ms) : 0, 29329
IAST [candidate] (30.217 ms) : 0, 30217
AppSec [baseline] (48.519 ms) : 0, 48519
AppSec [candidate] (48.816 ms) : 0, 48816
Debugger [baseline] (5.897 ms) : 0, 5897
Debugger [candidate] (5.906 ms) : 0, 5906
Remote Config [baseline] (586.998 µs) : 0, 587
Remote Config [candidate] (599.904 µs) : 0, 600
Telemetry [baseline] (7.898 ms) : 0, 7898
Telemetry [candidate] (7.928 ms) : 0, 7928
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (804.832 ms) : 0, 804832
BytebuddyAgent [candidate] (807.322 ms) : 0, 807322
GlobalTracer [baseline] (230.35 ms) : 0, 230350
GlobalTracer [candidate] (232.261 ms) : 0, 232261
IAST [baseline] (29.998 ms) : 0, 29998
IAST [candidate] (31.021 ms) : 0, 31021
AppSec [baseline] (48.502 ms) : 0, 48502
AppSec [candidate] (47.876 ms) : 0, 47876
Debugger [baseline] (5.908 ms) : 0, 5908
Debugger [candidate] (5.958 ms) : 0, 5958
Remote Config [baseline] (621.914 µs) : 0, 622
Remote Config [candidate] (593.933 µs) : 0, 594
Telemetry [baseline] (7.948 ms) : 0, 7948
Telemetry [candidate] (8.007 ms) : 0, 8007
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.62 ms) : 0, 803620
BytebuddyAgent [candidate] (797.773 ms) : 0, 797773
GlobalTracer [baseline] (230.955 ms) : 0, 230955
GlobalTracer [candidate] (230.672 ms) : 0, 230672
IAST [baseline] (23.928 ms) : 0, 23928
IAST [candidate] (23.863 ms) : 0, 23863
AppSec [baseline] (54.116 ms) : 0, 54116
AppSec [candidate] (54.106 ms) : 0, 54106
Debugger [baseline] (5.978 ms) : 0, 5978
Debugger [candidate] (5.939 ms) : 0, 5939
Remote Config [baseline] (617.999 µs) : 0, 618
Remote Config [candidate] (595.945 µs) : 0, 596
Telemetry [baseline] (7.771 ms) : 0, 7771
Telemetry [candidate] (7.784 ms) : 0, 7784
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~6783698498, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1336, 1375
. : milestone, 1356,
appsec (1.751 ms) : 1727, 1775
. : milestone, 1751,
appsec_no_iast (1.732 ms) : 1708, 1756
. : milestone, 1732,
code_origins (1.678 ms) : 1651, 1706
. : milestone, 1678,
iast (1.507 ms) : 1483, 1531
. : milestone, 1507,
profiling (1.526 ms) : 1503, 1550
. : milestone, 1526,
tracing (1.501 ms) : 1476, 1526
. : milestone, 1501,
section candidate
no_agent (1.373 ms) : 1355, 1392
. : milestone, 1373,
appsec (1.735 ms) : 1713, 1758
. : milestone, 1735,
appsec_no_iast (1.724 ms) : 1701, 1748
. : milestone, 1724,
code_origins (1.681 ms) : 1654, 1709
. : milestone, 1681,
iast (1.525 ms) : 1500, 1550
. : milestone, 1525,
profiling (1.539 ms) : 1515, 1563
. : milestone, 1539,
tracing (1.489 ms) : 1464, 1514
. : milestone, 1489,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~6783698498, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (384.012 µs) : 363, 405
. : milestone, 384,
iast (525.768 µs) : 502, 550
. : milestone, 526,
iast_FULL (738.264 µs) : 716, 760
. : milestone, 738,
iast_GLOBAL (559.202 µs) : 538, 581
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (527.312 µs) : 504, 550
. : milestone, 527,
iast_INACTIVE (465.266 µs) : 443, 487
. : milestone, 465,
iast_TELEMETRY_OFF (520.058 µs) : 497, 543
. : milestone, 520,
tracing (462.783 µs) : 441, 485
. : milestone, 463,
section candidate
no_agent (392.834 µs) : 372, 413
. : milestone, 393,
iast (529.939 µs) : 507, 553
. : milestone, 530,
iast_FULL (741.448 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (571.467 µs) : 550, 593
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (534.728 µs) : 512, 558
. : milestone, 535,
iast_INACTIVE (466.517 µs) : 444, 489
. : milestone, 467,
iast_TELEMETRY_OFF (511.491 µs) : 488, 535
. : milestone, 511,
tracing (462.856 µs) : 441, 485
. : milestone, 463,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~6783698498, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (14.76 s) : 14760000, 14760000
. : milestone, 14760000,
appsec (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
iast (18.702 s) : 18702000, 18702000
. : milestone, 18702000,
iast_GLOBAL (17.997 s) : 17997000, 17997000
. : milestone, 17997000,
profiling (15.106 s) : 15106000, 15106000
. : milestone, 15106000,
tracing (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
section candidate
no_agent (15.375 s) : 15375000, 15375000
. : milestone, 15375000,
appsec (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
iast (18.25 s) : 18250000, 18250000
. : milestone, 18250000,
iast_GLOBAL (18.13 s) : 18130000, 18130000
. : milestone, 18130000,
profiling (15.762 s) : 15762000, 15762000
. : milestone, 15762000,
tracing (14.915 s) : 14915000, 14915000
. : milestone, 14915000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~6783698498, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (2.406 ms) : 2357, 2454
. : milestone, 2406,
iast (2.17 ms) : 2109, 2230
. : milestone, 2170,
iast_GLOBAL (2.227 ms) : 2166, 2289
. : milestone, 2227,
profiling (2.022 ms) : 1973, 2070
. : milestone, 2022,
tracing (2.01 ms) : 1963, 2057
. : milestone, 2010,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.412 ms) : 2364, 2461
. : milestone, 2412,
iast (2.187 ms) : 2126, 2248
. : milestone, 2187,
iast_GLOBAL (2.221 ms) : 2160, 2282
. : milestone, 2221,
profiling (2.033 ms) : 1984, 2083
. : milestone, 2033,
tracing (2.016 ms) : 1968, 2063
. : milestone, 2016,
|
Thanks for adjusting the tests! |
What Does This Do
Minor change to check zstd compression in the profile uploading E2E workflow alongside the testing in #8862.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-11793