Fix CodeOrigin for `@Trace` annotation #8344

jpbempel · 2025-02-06T09:53:15Z

What Does This Do

add a param for captureCodeOrigin method to indicate if we need to
instrument for the CodeOriginProbe. the instrumentation for the
@trace annotation insert a call to start and activate the span.
so we just need to call captureCodeOrigin after the activation so we
benefit from tracer instrumentation without generating a call to
CodeOrigin probe.
That way are in sync with the tracer instrumentation.
add smoke test

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3449

pr-commenter · 2025-02-06T10:11:44Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1739361622	1739361992
end_time	2025-02-12T12:01:39	2025-02-12T12:07:49
git_branch	master	jpbempel/fix-code-origin-trace-annot
git_commit_sha	`429031c`	`f350dc8`
start_time	2025-02-12T12:00:23	2025-02-12T12:06:33

See matching parameters

	Baseline	Candidate
ci_job_id	804669292	804669292
ci_pipeline_id	55650304	55650304
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1739360994	1739360994

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 5 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	worse [+126.067µs; +254.675µs] or [+1.263%; +2.551%]	worse [+121.820µs; +266.154µs] or [+1.201%; +2.624%]	worse [+113.365µs; +283.564µs] or [+1.106%; +2.765%]	same	unsure [-2.617op/s; -0.170op/s] or [-2.695%; -0.175%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-21.044µs; +31.399µs] or [-7.786%; +11.617%]	unstable [-31.270µs; +43.941µs] or [-10.137%; +14.244%]	unstable [-41.149µs; +58.897µs] or [-12.795%; +18.313%]	unstable [-93.336µs; +103.056µs] or [-15.537%; +17.155%]	same
scenario:basic	same	same	same	unstable [-27.331µs; +76.831µs] or [-5.066%; +14.241%]	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (308.485 µs) : 280, 337
.   : milestone, 308,
basic (307.536 µs) : 299, 316
.   : milestone, 308,
loop (10.144 ms) : 10117, 10170
.   : milestone, 10144,
section candidate
noprobe (314.821 µs) : 273, 357
.   : milestone, 315,
basic (313.844 µs) : 303, 325
.   : milestone, 314,
loop (10.338 ms) : 10247, 10429
.   : milestone, 10338,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	308.485 µs [280.464 µs, 336.506 µs]
basic	307.536 µs [298.703 µs, 316.368 µs]
loop	10.144 ms [10.117 ms, 10.17 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	314.821 µs [272.575 µs, 357.066 µs]
basic	313.844 µs [302.877 µs, 324.812 µs]
loop	10.338 ms [10.247 ms, 10.429 ms]

pr-commenter · 2025-02-06T10:31:41Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-code-origin-trace-annot
git_commit_date	1739357650	1739360994
git_commit_sha	`429031c`	`f350dc8`
release_version	1.47.0-SNAPSHOT~429031c283	1.47.0-SNAPSHOT~f350dc8618

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739363390	1739363390
ci_job_id	804669286	804669286
ci_pipeline_id	55650304	55650304
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-uzizv6n-project-304-concurrent-0-2p2lxdad 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-uzizv6n-project-304-concurrent-0-2p2lxdad 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~f350dc8618, baseline=1.47.0-SNAPSHOT~429031c283

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055223
Total [baseline] (8.732 s) : 0, 8732275
Agent [candidate] (1.046 s) : 0, 1045829
Total [candidate] (8.612 s) : 0, 8611912
section iast
Agent [baseline] (1.179 s) : 0, 1179272
Total [baseline] (9.182 s) : 0, 9182219
Agent [candidate] (1.186 s) : 0, 1186190
Total [candidate] (9.199 s) : 0, 9199062
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1170499
Total [baseline] (9.196 s) : 0, 9195777
Agent [candidate] (1.174 s) : 0, 1174300
Total [candidate] (9.174 s) : 0, 9174231
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1167078
Total [baseline] (9.21 s) : 0, 9210023
Agent [candidate] (1.181 s) : 0, 1181175
Total [candidate] (9.211 s) : 0, 9210608

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	iast	1.179 s	124.049 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.17 s	115.276 ms (10.9%)
Agent	iast_TELEMETRY_OFF	1.167 s	111.855 ms (10.6%)
Total	tracing	8.732 s	-
Total	iast	9.182 s	449.944 ms (5.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.196 s	463.501 ms (5.3%)
Total	iast_TELEMETRY_OFF	9.21 s	477.747 ms (5.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	iast	1.186 s	140.361 ms (13.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	128.471 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.181 s	135.345 ms (12.9%)
Total	tracing	8.612 s	-
Total	iast	9.199 s	587.149 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.174 s	562.318 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.211 s	598.696 ms (7.0%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~f350dc8618, baseline=1.47.0-SNAPSHOT~429031c283

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.169 ms) : 0, 725169
BytebuddyAgent [candidate] (719.823 ms) : 0, 719823
GlobalTracer [baseline] (245.715 ms) : 0, 245715
GlobalTracer [candidate] (244.003 ms) : 0, 244003
AppSec [baseline] (56.013 ms) : 0, 56013
AppSec [candidate] (54.73 ms) : 0, 54730
Remote Config [baseline] (733.889 µs) : 0, 734
Remote Config [candidate] (706.828 µs) : 0, 707
Telemetry [baseline] (12.24 ms) : 0, 12240
Telemetry [candidate] (11.403 ms) : 0, 11403
section iast
BytebuddyAgent [baseline] (840.369 ms) : 0, 840369
BytebuddyAgent [candidate] (844.906 ms) : 0, 844906
GlobalTracer [baseline] (234.341 ms) : 0, 234341
GlobalTracer [candidate] (235.791 ms) : 0, 235791
IAST [baseline] (23.663 ms) : 0, 23663
IAST [candidate] (23.901 ms) : 0, 23901
AppSec [baseline] (56.274 ms) : 0, 56274
AppSec [candidate] (56.696 ms) : 0, 56696
Remote Config [baseline] (617.128 µs) : 0, 617
Remote Config [candidate] (623.435 µs) : 0, 623
Telemetry [baseline] (8.732 ms) : 0, 8732
Telemetry [candidate] (8.833 ms) : 0, 8833
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.329 ms) : 0, 833329
BytebuddyAgent [candidate] (835.043 ms) : 0, 835043
GlobalTracer [baseline] (233.444 ms) : 0, 233444
GlobalTracer [candidate] (233.977 ms) : 0, 233977
IAST [baseline] (22.719 ms) : 0, 22719
IAST [candidate] (22.931 ms) : 0, 22931
AppSec [baseline] (56.52 ms) : 0, 56520
AppSec [candidate] (57.73 ms) : 0, 57730
Remote Config [baseline] (611.314 µs) : 0, 611
Remote Config [candidate] (615.067 µs) : 0, 615
Telemetry [baseline] (8.69 ms) : 0, 8690
Telemetry [candidate] (8.772 ms) : 0, 8772
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.539 ms) : 0, 830539
BytebuddyAgent [candidate] (842.062 ms) : 0, 842062
GlobalTracer [baseline] (233.134 ms) : 0, 233134
GlobalTracer [candidate] (234.918 ms) : 0, 234918
IAST [baseline] (23.812 ms) : 0, 23812
IAST [candidate] (25.009 ms) : 0, 25009
AppSec [baseline] (55.236 ms) : 0, 55236
AppSec [candidate] (54.612 ms) : 0, 54612
Remote Config [baseline] (607.276 µs) : 0, 607
Remote Config [candidate] (607.719 µs) : 0, 608
Telemetry [baseline] (8.533 ms) : 0, 8533
Telemetry [candidate] (8.549 ms) : 0, 8549

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~f350dc8618, baseline=1.47.0-SNAPSHOT~429031c283

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045780
Total [baseline] (10.478 s) : 0, 10478244
Agent [candidate] (1.046 s) : 0, 1045786
Total [candidate] (10.479 s) : 0, 10479325
section appsec
Agent [baseline] (1.19 s) : 0, 1189580
Total [baseline] (10.777 s) : 0, 10777448
Agent [candidate] (1.189 s) : 0, 1189385
Total [candidate] (10.775 s) : 0, 10774540
section iast
Agent [baseline] (1.187 s) : 0, 1186955
Total [baseline] (11.049 s) : 0, 11049192
Agent [candidate] (1.171 s) : 0, 1170691
Total [candidate] (11.025 s) : 0, 11024954
section profiling
Agent [baseline] (1.26 s) : 0, 1259864
Total [baseline] (10.826 s) : 0, 10826115
Agent [candidate] (1.266 s) : 0, 1265842
Total [candidate] (10.855 s) : 0, 10854796

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.19 s	143.801 ms (13.8%)
Agent	iast	1.187 s	141.175 ms (13.5%)
Agent	profiling	1.26 s	214.085 ms (20.5%)
Total	tracing	10.478 s	-
Total	appsec	10.777 s	299.204 ms (2.9%)
Total	iast	11.049 s	570.948 ms (5.4%)
Total	profiling	10.826 s	347.872 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.189 s	143.599 ms (13.7%)
Agent	iast	1.171 s	124.905 ms (11.9%)
Agent	profiling	1.266 s	220.056 ms (21.0%)
Total	tracing	10.479 s	-
Total	appsec	10.775 s	295.215 ms (2.8%)
Total	iast	11.025 s	545.629 ms (5.2%)
Total	profiling	10.855 s	375.471 ms (3.6%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~f350dc8618, baseline=1.47.0-SNAPSHOT~429031c283

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.451 ms) : 0, 717451
BytebuddyAgent [candidate] (717.207 ms) : 0, 717207
GlobalTracer [baseline] (243.585 ms) : 0, 243585
GlobalTracer [candidate] (243.127 ms) : 0, 243127
AppSec [baseline] (55.142 ms) : 0, 55142
AppSec [candidate] (55.284 ms) : 0, 55284
Remote Config [baseline] (710.168 µs) : 0, 710
Remote Config [candidate] (719.199 µs) : 0, 719
Telemetry [baseline] (13.712 ms) : 0, 13712
Telemetry [candidate] (14.283 ms) : 0, 14283
section appsec
BytebuddyAgent [baseline] (736.458 ms) : 0, 736458
BytebuddyAgent [candidate] (736.109 ms) : 0, 736109
GlobalTracer [baseline] (241.289 ms) : 0, 241289
GlobalTracer [candidate] (241.118 ms) : 0, 241118
IAST [baseline] (21.806 ms) : 0, 21806
IAST [candidate] (21.802 ms) : 0, 21802
AppSec [baseline] (176.68 ms) : 0, 176680
AppSec [candidate] (177.013 ms) : 0, 177013
Remote Config [baseline] (656.593 µs) : 0, 657
Remote Config [candidate] (667.361 µs) : 0, 667
Telemetry [baseline] (8.307 ms) : 0, 8307
Telemetry [candidate] (8.315 ms) : 0, 8315
section iast
BytebuddyAgent [baseline] (846.768 ms) : 0, 846768
BytebuddyAgent [candidate] (832.759 ms) : 0, 832759
GlobalTracer [baseline] (235.227 ms) : 0, 235227
GlobalTracer [candidate] (233.267 ms) : 0, 233267
IAST [baseline] (22.895 ms) : 0, 22895
IAST [candidate] (22.886 ms) : 0, 22886
AppSec [baseline] (57.17 ms) : 0, 57170
AppSec [candidate] (57.242 ms) : 0, 57242
Remote Config [baseline] (615.017 µs) : 0, 615
Remote Config [candidate] (625.978 µs) : 0, 626
Telemetry [baseline] (8.735 ms) : 0, 8735
Telemetry [candidate] (8.679 ms) : 0, 8679
section profiling
BytebuddyAgent [baseline] (704.525 ms) : 0, 704525
BytebuddyAgent [candidate] (707.897 ms) : 0, 707897
GlobalTracer [baseline] (352.861 ms) : 0, 352861
GlobalTracer [candidate] (355.737 ms) : 0, 355737
AppSec [baseline] (55.045 ms) : 0, 55045
AppSec [candidate] (54.354 ms) : 0, 54354
Remote Config [baseline] (697.978 µs) : 0, 698
Remote Config [candidate] (702.859 µs) : 0, 703
Telemetry [baseline] (8.825 ms) : 0, 8825
Telemetry [candidate] (8.932 ms) : 0, 8932
ProfilingAgent [baseline] (95.677 ms) : 0, 95677
ProfilingAgent [candidate] (95.939 ms) : 0, 95939
Profiling [baseline] (95.701 ms) : 0, 95701
Profiling [candidate] (95.963 ms) : 0, 95963

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-12T11:59:46	2025-02-12T12:06:50
git_branch	master	jpbempel/fix-code-origin-trace-annot
git_commit_date	1739357650	1739360994
git_commit_sha	`429031c`	`f350dc8`
release_version	1.47.0-SNAPSHOT~429031c283	1.47.0-SNAPSHOT~f350dc8618
start_time	2025-02-12T11:59:32	2025-02-12T12:06:36

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739362369	1739362369
ci_job_id	804669287	804669287
ci_pipeline_id	55650304	55650304
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-uzizv6n-project-304-concurrent-1-uvi37hka 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-uzizv6n-project-304-concurrent-1-uvi37hka 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	better [-89.412µs; -37.185µs] or [-5.694%; -2.368%]	unstable [-441.365op/s; +669.285op/s] or [-14.896%; +22.588%]	1.507ms	3076.923op/s	1.570ms	2962.963op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~f350dc8618, baseline=1.47.0-SNAPSHOT~429031c283
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.305 µs) : 357, 396
.   : milestone, 376,
iast (512.672 µs) : 491, 534
.   : milestone, 513,
iast_FULL (740.37 µs) : 718, 762
.   : milestone, 740,
iast_GLOBAL (557.446 µs) : 535, 580
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (503.309 µs) : 482, 525
.   : milestone, 503,
iast_INACTIVE (461.482 µs) : 440, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (494.122 µs) : 472, 517
.   : milestone, 494,
tracing (452.758 µs) : 432, 473
.   : milestone, 453,
section candidate
no_agent (378.044 µs) : 357, 399
.   : milestone, 378,
iast (508.101 µs) : 486, 530
.   : milestone, 508,
iast_FULL (744.012 µs) : 722, 766
.   : milestone, 744,
iast_GLOBAL (551.456 µs) : 530, 573
.   : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (510.314 µs) : 489, 532
.   : milestone, 510,
iast_INACTIVE (460.593 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (494.553 µs) : 472, 517
.   : milestone, 495,
tracing (456.14 µs) : 435, 477
.   : milestone, 456,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.305 µs [356.68 µs, 395.93 µs]	-
iast	512.672 µs [491.2 µs, 534.143 µs]	136.366 µs (36.2%)
iast_FULL	740.37 µs [718.451 µs, 762.289 µs]	364.065 µs (96.7%)
iast_GLOBAL	557.446 µs [534.878 µs, 580.013 µs]	181.141 µs (48.1%)
iast_HARDCODED_SECRET_DISABLED	503.309 µs [481.856 µs, 524.761 µs]	127.004 µs (33.8%)
iast_INACTIVE	461.482 µs [439.794 µs, 483.169 µs]	85.177 µs (22.6%)
iast_TELEMETRY_OFF	494.122 µs [471.684 µs, 516.56 µs]	117.817 µs (31.3%)
tracing	452.758 µs [432.112 µs, 473.404 µs]	76.453 µs (20.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.044 µs [357.305 µs, 398.784 µs]	-
iast	508.101 µs [486.401 µs, 529.8 µs]	130.056 µs (34.4%)
iast_FULL	744.012 µs [722.136 µs, 765.888 µs]	365.968 µs (96.8%)
iast_GLOBAL	551.456 µs [529.971 µs, 572.94 µs]	173.411 µs (45.9%)
iast_HARDCODED_SECRET_DISABLED	510.314 µs [488.577 µs, 532.051 µs]	132.27 µs (35.0%)
iast_INACTIVE	460.593 µs [438.934 µs, 482.252 µs]	82.549 µs (21.8%)
iast_TELEMETRY_OFF	494.553 µs [472.192 µs, 516.913 µs]	116.508 µs (30.8%)
tracing	456.14 µs [434.806 µs, 477.474 µs]	78.096 µs (20.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~f350dc8618, baseline=1.47.0-SNAPSHOT~429031c283
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1372
.   : milestone, 1352,
appsec (1.729 ms) : 1706, 1752
.   : milestone, 1729,
appsec_no_iast (1.747 ms) : 1723, 1772
.   : milestone, 1747,
iast (1.5 ms) : 1474, 1525
.   : milestone, 1500,
profiling (1.57 ms) : 1545, 1596
.   : milestone, 1570,
tracing (1.492 ms) : 1468, 1517
.   : milestone, 1492,
section candidate
no_agent (1.377 ms) : 1357, 1396
.   : milestone, 1377,
appsec (1.765 ms) : 1742, 1788
.   : milestone, 1765,
appsec_no_iast (1.758 ms) : 1736, 1780
.   : milestone, 1758,
iast (1.512 ms) : 1489, 1536
.   : milestone, 1512,
profiling (1.507 ms) : 1484, 1530
.   : milestone, 1507,
tracing (1.48 ms) : 1455, 1505
.   : milestone, 1480,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.352 ms [1.332 ms, 1.372 ms]	-
appsec	1.729 ms [1.706 ms, 1.752 ms]	376.777 µs (27.9%)
appsec_no_iast	1.747 ms [1.723 ms, 1.772 ms]	395.128 µs (29.2%)
iast	1.5 ms [1.474 ms, 1.525 ms]	147.41 µs (10.9%)
profiling	1.57 ms [1.545 ms, 1.596 ms]	218.286 µs (16.1%)
tracing	1.492 ms [1.468 ms, 1.517 ms]	140.256 µs (10.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.377 ms [1.357 ms, 1.396 ms]	-
appsec	1.765 ms [1.742 ms, 1.788 ms]	388.204 µs (28.2%)
appsec_no_iast	1.758 ms [1.736 ms, 1.78 ms]	381.293 µs (27.7%)
iast	1.512 ms [1.489 ms, 1.536 ms]	135.816 µs (9.9%)
profiling	1.507 ms [1.484 ms, 1.53 ms]	130.429 µs (9.5%)
tracing	1.48 ms [1.455 ms, 1.505 ms]	103.67 µs (7.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-code-origin-trace-annot
git_commit_date	1739357650	1739360994
git_commit_sha	`429031c`	`f350dc8`
release_version	1.47.0-SNAPSHOT~429031c283	1.47.0-SNAPSHOT~f350dc8618

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1739362943	1739362943
ci_job_id	804669288	804669288
ci_pipeline_id	55650304	55650304
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-uzizv6n-project-304-concurrent-2-tqqr9rqy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-uzizv6n-project-304-concurrent-2-tqqr9rqy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~f350dc8618, baseline=1.47.0-SNAPSHOT~429031c283
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.368 ms) : 2324, 2411
.   : milestone, 2368,
iast (2.122 ms) : 2066, 2178
.   : milestone, 2122,
iast_GLOBAL (2.159 ms) : 2103, 2215
.   : milestone, 2159,
profiling (1.975 ms) : 1931, 2019
.   : milestone, 1975,
tracing (1.938 ms) : 1895, 1981
.   : milestone, 1938,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.374 ms) : 2330, 2418
.   : milestone, 2374,
iast (2.125 ms) : 2069, 2181
.   : milestone, 2125,
iast_GLOBAL (2.16 ms) : 2104, 2216
.   : milestone, 2160,
profiling (1.985 ms) : 1940, 2031
.   : milestone, 1985,
tracing (1.96 ms) : 1917, 2003
.   : milestone, 1960,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	2.368 ms [2.324 ms, 2.411 ms]	898.3 µs (61.1%)
iast	2.122 ms [2.066 ms, 2.178 ms]	652.58 µs (44.4%)
iast_GLOBAL	2.159 ms [2.103 ms, 2.215 ms]	689.685 µs (46.9%)
profiling	1.975 ms [1.931 ms, 2.019 ms]	505.89 µs (34.4%)
tracing	1.938 ms [1.895 ms, 1.981 ms]	468.678 µs (31.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.461 ms, 1.484 ms]	-
appsec	2.374 ms [2.33 ms, 2.418 ms]	901.417 µs (61.2%)
iast	2.125 ms [2.069 ms, 2.181 ms]	652.728 µs (44.3%)
iast_GLOBAL	2.16 ms [2.104 ms, 2.216 ms]	687.998 µs (46.7%)
profiling	1.985 ms [1.94 ms, 2.031 ms]	513.009 µs (34.8%)
tracing	1.96 ms [1.917 ms, 2.003 ms]	487.513 µs (33.1%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~f350dc8618, baseline=1.47.0-SNAPSHOT~429031c283
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.6 s) : 15600000, 15600000
.   : milestone, 15600000,
appsec (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
iast (19.068 s) : 19068000, 19068000
.   : milestone, 19068000,
iast_GLOBAL (17.968 s) : 17968000, 17968000
.   : milestone, 17968000,
profiling (15.657 s) : 15657000, 15657000
.   : milestone, 15657000,
tracing (15.128 s) : 15128000, 15128000
.   : milestone, 15128000,
section candidate
no_agent (14.889 s) : 14889000, 14889000
.   : milestone, 14889000,
appsec (15.224 s) : 15224000, 15224000
.   : milestone, 15224000,
iast (18.038 s) : 18038000, 18038000
.   : milestone, 18038000,
iast_GLOBAL (17.961 s) : 17961000, 17961000
.   : milestone, 17961000,
profiling (15.101 s) : 15101000, 15101000
.   : milestone, 15101000,
tracing (15.061 s) : 15061000, 15061000
.   : milestone, 15061000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.6 s [15.6 s, 15.6 s]	-
appsec	14.988 s [14.988 s, 14.988 s]	-612.0 ms (-3.9%)
iast	19.068 s [19.068 s, 19.068 s]	3.468 s (22.2%)
iast_GLOBAL	17.968 s [17.968 s, 17.968 s]	2.368 s (15.2%)
profiling	15.657 s [15.657 s, 15.657 s]	57.0 ms (0.4%)
tracing	15.128 s [15.128 s, 15.128 s]	-472.0 ms (-3.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.889 s [14.889 s, 14.889 s]	-
appsec	15.224 s [15.224 s, 15.224 s]	335.0 ms (2.2%)
iast	18.038 s [18.038 s, 18.038 s]	3.149 s (21.1%)
iast_GLOBAL	17.961 s [17.961 s, 17.961 s]	3.072 s (20.6%)
profiling	15.101 s [15.101 s, 15.101 s]	212.0 ms (1.4%)
tracing	15.061 s [15.061 s, 15.061 s]	172.0 ms (1.2%)

shatzi · 2025-02-08T06:30:14Z

.../agent-debugger/src/main/java/com/datadog/debugger/codeorigin/DefaultCodeOriginRecorder.java

    String fingerprint = method.toString();
    CodeOriginProbe probe = probesByFingerprint.get(fingerprint);
    if (probe == null) {
-      probe = createProbe(fingerprint, entry, Where.of(method));
+      probe = createProbe(fingerprint, entry, Where.of(method), instrument);


We are not calling probe.commit() here. but if insturment is false... we should call commit every time, right?
maybe change the else if below. and just have

if (!instrument) { probe.commit() }

createProbe is calling probe.commit()

@trace

add a param for captureCodeOrigin method to indicate if we need to instrument for the CodeOriginProbe. the instrumentation for the @trace annotation insert a call to start and activate the span. so we just need to call captureCodeOrigin after the activation so we benefit from tracer instrumentation without generating a call to CodeOriginProbe. That way are in sync with the tracer instrumentation. add smoke test

* backport pr #8344 * Fix GrpcCodeOriginTest * Fix muzzle directive for java 11 --------- Co-authored-by: Manuel Álvarez Álvarez <manuel.alvarezalvarez@datadoghq.com>

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

jpbempel added comp: debugger Dynamic Instrumentation type: bug labels Feb 6, 2025

jpbempel force-pushed the jpbempel/fix-code-origin-trace-annot branch 3 times, most recently from 683c682 to 8871f09 Compare February 6, 2025 17:08

jpbempel marked this pull request as ready for review February 6, 2025 17:09

jpbempel requested review from a team as code owners February 6, 2025 17:09

jpbempel requested review from ojung and removed request for a team February 6, 2025 17:09

jpbempel force-pushed the jpbempel/fix-code-origin-trace-annot branch from 8871f09 to f1458bf Compare February 6, 2025 17:26

shatzi approved these changes Feb 8, 2025

View reviewed changes

jpbempel force-pushed the jpbempel/fix-code-origin-trace-annot branch from f1458bf to fd61031 Compare February 12, 2025 10:46

jpbempel force-pushed the jpbempel/fix-code-origin-trace-annot branch from fd61031 to f350dc8 Compare February 12, 2025 11:50

jpbempel merged commit a2be60e into master Feb 12, 2025
207 checks passed

jpbempel deleted the jpbempel/fix-code-origin-trace-annot branch February 12, 2025 13:16

github-actions bot added this to the 1.47.0 milestone Feb 12, 2025

evanchooly added a commit that referenced this pull request Feb 19, 2025

backport pr #8344

7719ee9

evanchooly mentioned this pull request Feb 19, 2025

🍒 8344 - Fix CodeOrigin for @Trace annotation #8425

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix CodeOrigin for `@Trace` annotation #8344

Fix CodeOrigin for `@Trace` annotation #8344

Uh oh!

jpbempel commented Feb 6, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Feb 6, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Feb 6, 2025 •

edited

Loading

Uh oh!

shatzi Feb 8, 2025

Uh oh!

jpbempel Feb 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Fix CodeOrigin for @Trace annotation #8344

Fix CodeOrigin for @Trace annotation #8344

Uh oh!

Conversation

jpbempel commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenter bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

shatzi Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

jpbempel Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Fix CodeOrigin for `@Trace` annotation #8344

Fix CodeOrigin for `@Trace` annotation #8344

jpbempel commented Feb 6, 2025 •

edited

Loading

pr-commenter bot commented Feb 6, 2025 •

edited

Loading

pr-commenter bot commented Feb 6, 2025 •

edited

Loading

jpbempel Feb 10, 2025 •

edited

Loading