Add tracing of setup and teardown actions in JUnit 4 #8030

daniel-mohedano · 2024-11-28T10:25:19Z

What Does This Do

Implements tracing of setup and teardown actions available in JUnit 4 (@Before, @After, @BeforeClass, @AfterClass, @BeforeParam, @AfterParam).

Motivation

To provide more complete information regarding test runs, the setup and teardown actions can be traced. This is already implemented for JUnit 5, which implies that it would also be nice to have for JUnit 4.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: SDTEST-1224

pr-commenter · 2024-11-28T11:02:24Z

Benchmarks

Startup

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-29T11:41:13	2024-11-29T11:48:14
git_branch	master	daniel.mohedano/SDTEST-1224-setup-teardown-tracing-junit4
git_commit_date	1732876820	1732879953
git_commit_sha	`9f01834`	`948fe8a`
release_version	1.44.0-SNAPSHOT~9f01834ab7	1.44.0-SNAPSHOT~948fe8ac30
start_time	2024-11-29T11:40:59	2024-11-29T11:48:01

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732881248	1732881248
ci_job_id	723438389	723438389
ci_pipeline_id	50141202	50141202
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~948fe8ac30, baseline=1.44.0-SNAPSHOT~9f01834ab7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1376
.   : milestone, 1357,
appsec (1.778 ms) : 1755, 1801
.   : milestone, 1778,
appsec_no_iast (1.767 ms) : 1742, 1792
.   : milestone, 1767,
iast (1.504 ms) : 1481, 1527
.   : milestone, 1504,
profiling (1.561 ms) : 1537, 1585
.   : milestone, 1561,
tracing (1.512 ms) : 1487, 1536
.   : milestone, 1512,
section candidate
no_agent (1.353 ms) : 1334, 1372
.   : milestone, 1353,
appsec (1.764 ms) : 1740, 1789
.   : milestone, 1764,
appsec_no_iast (1.77 ms) : 1745, 1794
.   : milestone, 1770,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.514 ms) : 1490, 1538
.   : milestone, 1514,
tracing (1.519 ms) : 1494, 1544
.   : milestone, 1519,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.357 ms [1.337 ms, 1.376 ms]	-
appsec	1.778 ms [1.755 ms, 1.801 ms]	421.323 µs (31.1%)
appsec_no_iast	1.767 ms [1.742 ms, 1.792 ms]	410.053 µs (30.2%)
iast	1.504 ms [1.481 ms, 1.527 ms]	147.444 µs (10.9%)
profiling	1.561 ms [1.537 ms, 1.585 ms]	204.183 µs (15.0%)
tracing	1.512 ms [1.487 ms, 1.536 ms]	154.958 µs (11.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.334 ms, 1.372 ms]	-
appsec	1.764 ms [1.74 ms, 1.789 ms]	411.549 µs (30.4%)
appsec_no_iast	1.77 ms [1.745 ms, 1.794 ms]	416.781 µs (30.8%)
iast	1.491 ms [1.468 ms, 1.514 ms]	138.115 µs (10.2%)
profiling	1.514 ms [1.49 ms, 1.538 ms]	161.456 µs (11.9%)
tracing	1.519 ms [1.494 ms, 1.544 ms]	166.149 µs (12.3%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~948fe8ac30, baseline=1.44.0-SNAPSHOT~9f01834ab7
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.368 µs) : 359, 398
.   : milestone, 378,
iast (492.647 µs) : 471, 514
.   : milestone, 493,
iast_FULL (655.985 µs) : 634, 678
.   : milestone, 656,
iast_GLOBAL (519.947 µs) : 499, 541
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (495.839 µs) : 475, 517
.   : milestone, 496,
iast_INACTIVE (451.754 µs) : 431, 472
.   : milestone, 452,
iast_TELEMETRY_OFF (489.516 µs) : 468, 511
.   : milestone, 490,
tracing (448.227 µs) : 428, 469
.   : milestone, 448,
section candidate
no_agent (380.47 µs) : 361, 400
.   : milestone, 380,
iast (494.585 µs) : 473, 516
.   : milestone, 495,
iast_FULL (660.218 µs) : 639, 682
.   : milestone, 660,
iast_GLOBAL (520.383 µs) : 499, 542
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (497.827 µs) : 476, 519
.   : milestone, 498,
iast_INACTIVE (453.714 µs) : 433, 474
.   : milestone, 454,
iast_TELEMETRY_OFF (479.762 µs) : 459, 501
.   : milestone, 480,
tracing (454.786 µs) : 434, 476
.   : milestone, 455,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.368 µs [358.682 µs, 398.053 µs]	-
iast	492.647 µs [471.36 µs, 513.934 µs]	114.279 µs (30.2%)
iast_FULL	655.985 µs [634.372 µs, 677.598 µs]	277.617 µs (73.4%)
iast_GLOBAL	519.947 µs [498.778 µs, 541.116 µs]	141.579 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED	495.839 µs [474.587 µs, 517.09 µs]	117.471 µs (31.0%)
iast_INACTIVE	451.754 µs [431.219 µs, 472.29 µs]	73.387 µs (19.4%)
iast_TELEMETRY_OFF	489.516 µs [467.667 µs, 511.365 µs]	111.148 µs (29.4%)
tracing	448.227 µs [427.775 µs, 468.678 µs]	69.859 µs (18.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.47 µs [360.716 µs, 400.224 µs]	-
iast	494.585 µs [472.997 µs, 516.173 µs]	114.115 µs (30.0%)
iast_FULL	660.218 µs [638.762 µs, 681.674 µs]	279.748 µs (73.5%)
iast_GLOBAL	520.383 µs [498.97 µs, 541.795 µs]	139.913 µs (36.8%)
iast_HARDCODED_SECRET_DISABLED	497.827 µs [476.233 µs, 519.422 µs]	117.358 µs (30.8%)
iast_INACTIVE	453.714 µs [432.983 µs, 474.444 µs]	73.244 µs (19.3%)
iast_TELEMETRY_OFF	479.762 µs [458.846 µs, 500.678 µs]	99.292 µs (26.1%)
tracing	454.786 µs [433.773 µs, 475.798 µs]	74.316 µs (19.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/SDTEST-1224-setup-teardown-tracing-junit4
git_commit_date	1732876820	1732879953
git_commit_sha	`9f01834`	`948fe8a`
release_version	1.44.0-SNAPSHOT~9f01834ab7	1.44.0-SNAPSHOT~948fe8ac30

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732881900	1732881900
ci_job_id	723438390	723438390
ci_pipeline_id	50141202	50141202
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~948fe8ac30, baseline=1.44.0-SNAPSHOT~9f01834ab7
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.398 s) : 15398000, 15398000
.   : milestone, 15398000,
appsec (15.0 s) : 15000000, 15000000
.   : milestone, 15000000,
iast (18.99 s) : 18990000, 18990000
.   : milestone, 18990000,
iast_GLOBAL (18.209 s) : 18209000, 18209000
.   : milestone, 18209000,
profiling (14.869 s) : 14869000, 14869000
.   : milestone, 14869000,
tracing (15.048 s) : 15048000, 15048000
.   : milestone, 15048000,
section candidate
no_agent (15.41 s) : 15410000, 15410000
.   : milestone, 15410000,
appsec (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
iast (18.36 s) : 18360000, 18360000
.   : milestone, 18360000,
iast_GLOBAL (17.692 s) : 17692000, 17692000
.   : milestone, 17692000,
profiling (15.258 s) : 15258000, 15258000
.   : milestone, 15258000,
tracing (14.933 s) : 14933000, 14933000
.   : milestone, 14933000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.398 s [15.398 s, 15.398 s]	-
appsec	15.0 s [15.0 s, 15.0 s]	-398.0 ms (-2.6%)
iast	18.99 s [18.99 s, 18.99 s]	3.592 s (23.3%)
iast_GLOBAL	18.209 s [18.209 s, 18.209 s]	2.811 s (18.3%)
profiling	14.869 s [14.869 s, 14.869 s]	-529.0 ms (-3.4%)
tracing	15.048 s [15.048 s, 15.048 s]	-350.0 ms (-2.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.41 s [15.41 s, 15.41 s]	-
appsec	14.946 s [14.946 s, 14.946 s]	-464.0 ms (-3.0%)
iast	18.36 s [18.36 s, 18.36 s]	2.95 s (19.1%)
iast_GLOBAL	17.692 s [17.692 s, 17.692 s]	2.282 s (14.8%)
profiling	15.258 s [15.258 s, 15.258 s]	-152.0 ms (-1.0%)
tracing	14.933 s [14.933 s, 14.933 s]	-477.0 ms (-3.1%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~948fe8ac30, baseline=1.44.0-SNAPSHOT~9f01834ab7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.339 ms) : 2297, 2380
.   : milestone, 2339,
iast (2.078 ms) : 2025, 2130
.   : milestone, 2078,
iast_GLOBAL (2.118 ms) : 2065, 2171
.   : milestone, 2118,
profiling (1.951 ms) : 1909, 1993
.   : milestone, 1951,
tracing (1.919 ms) : 1879, 1959
.   : milestone, 1919,
section candidate
no_agent (1.465 ms) : 1453, 1476
.   : milestone, 1465,
appsec (2.333 ms) : 2291, 2375
.   : milestone, 2333,
iast (2.076 ms) : 2023, 2128
.   : milestone, 2076,
iast_GLOBAL (2.118 ms) : 2065, 2170
.   : milestone, 2118,
profiling (1.954 ms) : 1911, 1998
.   : milestone, 1954,
tracing (1.917 ms) : 1878, 1957
.   : milestone, 1917,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.455 ms, 1.478 ms]	-
appsec	2.339 ms [2.297 ms, 2.38 ms]	871.869 µs (59.4%)
iast	2.078 ms [2.025 ms, 2.13 ms]	610.9 µs (41.7%)
iast_GLOBAL	2.118 ms [2.065 ms, 2.171 ms]	651.145 µs (44.4%)
profiling	1.951 ms [1.909 ms, 1.993 ms]	484.71 µs (33.0%)
tracing	1.919 ms [1.879 ms, 1.959 ms]	452.412 µs (30.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.465 ms [1.453 ms, 1.476 ms]	-
appsec	2.333 ms [2.291 ms, 2.375 ms]	868.645 µs (59.3%)
iast	2.076 ms [2.023 ms, 2.128 ms]	611.137 µs (41.7%)
iast_GLOBAL	2.118 ms [2.065 ms, 2.17 ms]	653.324 µs (44.6%)
profiling	1.954 ms [1.911 ms, 1.998 ms]	489.733 µs (33.4%)
tracing	1.917 ms [1.878 ms, 1.957 ms]	452.758 µs (30.9%)

…-tracing-junit4

github-actions · 2024-12-12T13:26:44Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#8089](DataDog/dd-trace-java#8089) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#8044](DataDog/dd-trace-java#8044) - [@smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#8038](DataDog/dd-trace-java#8038) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#8026](DataDog/dd-trace-java#8026) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#8013](DataDog/dd-trace-java#8013) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#8010](DataDog/dd-trace-java#8010) - [@Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#8004](DataDog/dd-trace-java#8004) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#8078](DataDog/dd-trace-java#8078) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#8055](DataDog/dd-trace-java#8055) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#8033](DataDog/dd-trace-java#8033) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#8030](DataDog/dd-trace-java#8030) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#8045](DataDog/dd-trace-java#8045) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#8071](DataDog/dd-trace-java#8071) - [@piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#8051](DataDog/dd-trace-java#8051) - [@kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#8039](DataDog/dd-trace-java#8039) - [@jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#8021](DataDog/dd-trace-java#8021) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#8016](DataDog/dd-trace-java#8016) - [@evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#7942](DataDog/dd-trace-java#7942) - [@evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#8065](DataDog/dd-trace-java#8065) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#8036](DataDog/dd-trace-java#8036) - [@mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#8058](DataDog/dd-trace-java#8058) - [@mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#8064](DataDog/dd-trace-java#8064) - [@amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#8061](DataDog/dd-trace-java#8061) - [@amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#8040](DataDog/dd-trace-java#8040) - [@cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#8028](DataDog/dd-trace-java#8028) - [@mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#7973](DataDog/dd-trace-java#7973) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#7946](DataDog/dd-trace-java#7946) - [@smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#8043](DataDog/dd-trace-java#8043) - [@amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#7940](DataDog/dd-trace-java#7940) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#8062](DataDog/dd-trace-java#8062) - [@amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#8019](DataDog/dd-trace-java#8019) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#8005](DataDog/dd-trace-java#8005) - [@amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#8025](DataDog/dd-trace-java#8025) - [@amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#7981](DataDog/dd-trace-java#7981) - [@amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c

daniel-mohedano added 7 commits November 26, 2024 12:32

add tracing for junit4 setup/teardown actions

407e5c7

update instrumentation test fixtures

43ffd7e

add new instrumentation for junit4.13

a52a400

Revert test fixture changes

4b1a69e

generate test fixtures for junit 4.13 instrumentation

b4f036b

junit4.13 muzzle check

5497d99

remove inverse muzzle assert

e8ae392

daniel-mohedano added 3 commits November 28, 2024 13:44

additional tests for failing setup and teardown

0df9f72

Merge branch 'master' into daniel.mohedano/SDTEST-1224-setup-teardown…

b1886ed

…-tracing-junit4

add junit 4.13 instrumentation to instrumentation testing config

5004300

daniel-mohedano added the comp: ci visibility Continuous Integration Visibility label Nov 29, 2024

daniel-mohedano added 2 commits November 29, 2024 10:40

Merge branch 'master' into daniel.mohedano/SDTEST-1224-setup-teardown…

f35cbd4

…-tracing-junit4

add support for BeforeParam and AfterParam

948fe8a

daniel-mohedano requested a review from nikita-tkachenko-datadog November 29, 2024 17:16

daniel-mohedano marked this pull request as ready for review December 2, 2024 10:25

daniel-mohedano requested review from a team as code owners December 2, 2024 10:25

daniel-mohedano requested a review from nayeem-kamal December 2, 2024 10:25

nikita-tkachenko-datadog approved these changes Dec 2, 2024

View reviewed changes

daniel-mohedano merged commit cdee1c8 into master Dec 2, 2024
103 checks passed

daniel-mohedano deleted the daniel.mohedano/SDTEST-1224-setup-teardown-tracing-junit4 branch December 2, 2024 11:04

github-actions bot added this to the 1.44.0 milestone Dec 2, 2024

PerfectSlayer changed the title ~~Tracing of setup and teardown actions in JUnit 4~~ Add tracing of setup and teardown actions in JUnit 4 Dec 12, 2024

PerfectSlayer added the type: enhancement label Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tracing of setup and teardown actions in JUnit 4 #8030

Add tracing of setup and teardown actions in JUnit 4 #8030

daniel-mohedano commented Nov 28, 2024 •

edited

Loading

pr-commenter bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024

Add tracing of setup and teardown actions in JUnit 4 #8030

Add tracing of setup and teardown actions in JUnit 4 #8030

Conversation

daniel-mohedano commented Nov 28, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Nov 28, 2024 • edited Loading

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary

github-actions bot commented Dec 12, 2024

daniel-mohedano commented Nov 28, 2024 •

edited

Loading

pr-commenter bot commented Nov 28, 2024 •

edited

Loading