Skip to content

Commit f3788e7

Browse files
committed
Improve comment
1 parent 073645c commit f3788e7

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

dd-java-agent/instrumentation/spring/spring-webmvc/spring-webmvc-3.1/src/main/java/datadog/trace/instrumentation/springweb/HttpMessageConverterInstrumentation.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,11 @@ public static void after(
108108

109109
// CharSequence or byte[] cannot be treated as parsed body content, as they may lead to false
110110
// positives in the WAF rules.
111+
// TODO: These types (CharSequence, byte[]) are candidates to being deserialized before being
112+
// sent to the WAF once we implement that feature.
113+
// Possible types received by this method include: String, byte[], various DTOs/POJOs,
114+
// Collections (List, Map), Jackson JsonNode objects, XML objects, etc.
115+
// We may need to add more types to this block list in the future.
111116
if (obj instanceof CharSequence || obj instanceof byte[]) {
112117
return;
113118
}

0 commit comments

Comments
 (0)