Skip to content

Commit dd12e29

Browse files
committed
Adapt tests
1 parent 0384afd commit dd12e29

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

dd-java-agent/instrumentation/tomcat-5.5/src/latestDepTest/groovy/TomcatServer.groovy

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ class TomcatServer implements WebsocketServer {
6565
port = server.service.findConnectors()[0].localPort
6666
assert port > 0
6767
if (Config.get().isExperimentalPropagateProcessTagsEnabled()) {
68+
server.getEngine().setName("tomcat")
6869
def serverName = TraceUtils.normalizeTag(server.getEngine().getName())
6970
assert ProcessTags.getTagsAsStringList().containsAll(["server.type:tomcat", "server.name:" + serverName])
7071
} else {

dd-smoke-tests/debugger-integration-tests/src/test/java/datadog/smoketest/TracerDebuggerIntegrationTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import com.datadog.debugger.probe.LogProbe;
1212
import com.datadog.debugger.sink.Snapshot;
1313
import com.squareup.moshi.JsonAdapter;
14+
import datadog.environment.JavaVirtualMachine;
1415
import datadog.trace.agent.test.utils.PortUtils;
1516
import datadog.trace.bootstrap.debugger.MethodLocation;
1617
import datadog.trace.bootstrap.debugger.ProbeId;
@@ -184,6 +185,9 @@ private JsonSnapshotSerializer.IntakeRequest doTestTracer(
184185
ProcessBuilder processBuilder = createProcessBuilder(logFilePath, "--server.port=" + httpPort);
185186
if (enableProcessTags) {
186187
processBuilder.environment().put("DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED", "true");
188+
} else if (JavaVirtualMachine.isJavaVersion(21)) {
189+
// disable explicitly since enable by default on 21
190+
processBuilder.environment().put("DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED", "false");
187191
}
188192
targetProcess = processBuilder.start();
189193
// assert in logs app started

remote-config/remote-config-core/src/test/groovy/datadog/remoteconfig/PollerRequestFactoryTest.groovy

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package datadog.remoteconfig
22

33
import com.squareup.moshi.Moshi
4+
import datadog.environment.JavaVirtualMachine
45
import datadog.remoteconfig.tuf.RemoteConfigRequest
56
import datadog.trace.api.ProcessTags
67
import datadog.trace.bootstrap.instrumentation.api.Tags
@@ -58,8 +59,11 @@ class PollerRequestFactoryTest extends DDSpecification {
5859

5960
void 'remote config provides process tags when enabled = #enabled'() {
6061
setup:
62+
// to be changed when activated by default
6163
if (enabled) {
6264
injectSysConfig(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, "true")
65+
} else if (JavaVirtualMachine.isJavaVersion(21)) {
66+
injectSysConfig(EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED, "false")
6367
}
6468
ProcessTags.reset()
6569
PollerRequestFactory factory = new PollerRequestFactory(Config.get(), TRACER_VERSION, CONTAINER_ID, ENTITY_ID, INVALID_REMOTE_CONFIG_URL, null)

0 commit comments

Comments
 (0)