Update the probe/snapshot format doc

Author: jbachorik

dd-java-agent/agent-debugging/src/main/docs/debugger_probes.md

@@ -8,6 +8,12 @@
   - java | python | go | c# | ...
 - **version**
   - the debugger version; used to properly maintain backward compatibility
+- **orgId**
+  - the organization ID
+- **appId**
+  - the application ID
+- **tags**
+  - list of tags associated with the probe
 - **where**
   - **typeName**
     - class/type name
@@ -65,6 +71,8 @@ _Note: this part will get replaced once we have debugger expressions figured out
   "language": "java",
   "probeId": "12fd-8490-c111-4374-ffde",
   "version": 0,
+  "orgId": 2,
+  "appId": "test-app",
   "where": {
     "typeName": "java.lang.Object",
     "methodName": "toString",
@@ -80,6 +88,8 @@ _Note: this part will get replaced once we have debugger expressions figured out
   "language": "java",
   "probeId": "12fd-8490-c111-4374-ffde",
   "version": 0,
+  "orgId": 2,
+  "appId": "test-app",
   "where": {
     "typeName": "java.lang.String",
     "methodName": "nonSyncContentEquals",
@@ -100,6 +110,8 @@ _Note: this part will get replaced once we have debugger expressions figured out
   "language": "java",
   "probeId": "12fd-8490-c111-4374-ffde",
   "version": 0,
+  "orgId": 2,
+  "appId": "test-app",
   "where": {
     "typeName": "java.lang.String",
     "methodName": "nonSyncContentEquals",
@@ -130,23 +142,41 @@ Snapshot is defined by:
   - a list of probe capture points
 
 #### Capture point
-- **location**
-  - **type**
-    - location type, one of:
-        - **entry** - method/function enter
-        - **exit** - method/function exit - both exceptional and non-exceptional exits are considered
-        - **before** - before the specified code line or code offset
-        - **after** - after the specified code line or offset
+- **kind**
+  - location kind, one of:
+    - **ENTER** - method/function enter
+    - **RETURN** - method/function standard return
+    - **UNHANDLED_EXCEPTION** - method/function exit due to unhandled exception
+    - **HANDLED_EXCEPTION** - method/function is handling an exception (eg. 'catch' handler)
+    - **BEFORE** - before the specified code line or code offset
+    - **AFTER** - after the specified code line or offset
   - _[optional] _**line**
     - the line number if `location` is either `before` or `after`
-- **argumentValues**
-  - a list of [type:value] tuples corresponding to the method/function arguments
-- _[optional]_ **localValues**
-  - a [name:[type:value]] map valid at a particular place in code
+- **arguments**
+  - a list of `CapturedValue` instances corresponding to the method/function arguments
+- _[optional]_ **locals**
+  - a list of `CapturedValue` instances corresponding to valid local variables
+  - not be available for `ENTER` kind
 - _[optional]_ **returnValue**
-  - [type:value] tuple representing the return value
-- _[optional]_ **thrownException**
-  - textual representation of the thrown exception
+  - a `CapturedValue` instance representing the return value
+  - available only for `RETURN` kind
+- _[optional]_ **throwable**
+  - a `CapturedThrowable` instance representing the thrown exception
+  - available only for `HANDLED_EXCEPTION` or `UNHANDLED_EXCEPTION` kinds
+
+#### CapturedValue
+- **name**
+  - the associated name (eg. argument name or local variable)
+- **type**
+  - the value type (if available)
+- **value**
+  - textual representation of the value
+
+#### CapturedThrowable
+- **type**
+  - the exception type
+- **message**
+  - the exception message
 
 ### Probe snapshot collection
 On method/function entry a new probe snapshot is open if permitted by the rate limiter.

dd-java-agent/agent-debugging/src/main/java/com/datadog/debugging/probes/ProbesPoller.java

@@ -13,7 +13,6 @@
 import java.util.Collections;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.ScheduledFuture;
 import java.util.concurrent.ThreadFactory;
 import java.util.concurrent.TimeUnit;
 import lombok.extern.slf4j.Slf4j;