Repository navigation
Commit 4a2bd4d
committed
Fix async blocking flag set before commit confirmation
NettyBlockResponseFunction.tryCommitBlockingResponse() marked
blockingResponseInitiated = true immediately after scheduling the
off-event-loop commitBlockingResponse() call, without waiting for it
to actually run. If that async commit failed once executed, the
failure was silently swallowed and every later tryBlock() call for
the same request would short-circuit to true, hiding the failure
from block_failure telemetry. The flag is now set only inside the
scheduled task, after commitBlockingResponse() actually returns true,
matching the same-thread branch's existing behavior.1 parent cdd1140 commit 4a2bd4d
1 file changed
Lines changed: 6 additions & 4 deletions
File tree
- dd-java-agent/instrumentation/netty/netty-4.1/src/main/java/datadog/trace/instrumentation/netty41/server
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
171 | 173 | | |
172 | 174 | | |
173 | 175 | | |
| |||
0 commit comments