Skip to content

Commit 4126e2e

Browse files
committed
follow java convention of naming Id instead of ID
1 parent b5c7a0a commit 4126e2e

File tree

2 files changed

+27
-27
lines changed

2 files changed

+27
-27
lines changed

dd-trace-api/src/main/java/datadog/trace/api/llmobs/LLMObs.java

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -15,33 +15,33 @@ public static LLMObsSpan startLLMSpan(
1515
String modelName,
1616
String modelProvider,
1717
@Nullable String mlApp,
18-
@Nullable String sessionID) {
18+
@Nullable String sessionId) {
1919

20-
return SPAN_FACTORY.startLLMSpan(spanName, modelName, modelProvider, mlApp, sessionID);
20+
return SPAN_FACTORY.startLLMSpan(spanName, modelName, modelProvider, mlApp, sessionId);
2121
}
2222

2323
public static LLMObsSpan startAgentSpan(
24-
String spanName, @Nullable String mlApp, @Nullable String sessionID) {
24+
String spanName, @Nullable String mlApp, @Nullable String sessionId) {
2525

26-
return SPAN_FACTORY.startAgentSpan(spanName, mlApp, sessionID);
26+
return SPAN_FACTORY.startAgentSpan(spanName, mlApp, sessionId);
2727
}
2828

2929
public static LLMObsSpan startToolSpan(
30-
String spanName, @Nullable String mlApp, @Nullable String sessionID) {
30+
String spanName, @Nullable String mlApp, @Nullable String sessionId) {
3131

32-
return SPAN_FACTORY.startToolSpan(spanName, mlApp, sessionID);
32+
return SPAN_FACTORY.startToolSpan(spanName, mlApp, sessionId);
3333
}
3434

3535
public static LLMObsSpan startTaskSpan(
36-
String spanName, @Nullable String mlApp, @Nullable String sessionID) {
36+
String spanName, @Nullable String mlApp, @Nullable String sessionId) {
3737

38-
return SPAN_FACTORY.startTaskSpan(spanName, mlApp, sessionID);
38+
return SPAN_FACTORY.startTaskSpan(spanName, mlApp, sessionId);
3939
}
4040

4141
public static LLMObsSpan startWorkflowSpan(
42-
String spanName, @Nullable String mlApp, @Nullable String sessionID) {
42+
String spanName, @Nullable String mlApp, @Nullable String sessionId) {
4343

44-
return SPAN_FACTORY.startWorkflowSpan(spanName, mlApp, sessionID);
44+
return SPAN_FACTORY.startWorkflowSpan(spanName, mlApp, sessionId);
4545
}
4646

4747
public interface LLMObsSpanFactory {
@@ -50,33 +50,33 @@ LLMObsSpan startLLMSpan(
5050
String modelName,
5151
String modelProvider,
5252
@Nullable String mlApp,
53-
@Nullable String sessionID);
53+
@Nullable String sessionId);
5454

55-
LLMObsSpan startAgentSpan(String spanName, @Nullable String mlApp, @Nullable String sessionID);
55+
LLMObsSpan startAgentSpan(String spanName, @Nullable String mlApp, @Nullable String sessionId);
5656

57-
LLMObsSpan startToolSpan(String spanName, @Nullable String mlApp, @Nullable String sessionID);
57+
LLMObsSpan startToolSpan(String spanName, @Nullable String mlApp, @Nullable String sessionId);
5858

59-
LLMObsSpan startTaskSpan(String spanName, @Nullable String mlApp, @Nullable String sessionID);
59+
LLMObsSpan startTaskSpan(String spanName, @Nullable String mlApp, @Nullable String sessionId);
6060

6161
LLMObsSpan startWorkflowSpan(
62-
String spanName, @Nullable String mlApp, @Nullable String sessionID);
62+
String spanName, @Nullable String mlApp, @Nullable String sessionId);
6363
}
6464

6565
public static class ToolCall {
6666
private String name;
6767
private String type;
68-
private String toolID;
68+
private String toolId;
6969
private Map<String, Object> arguments;
7070

7171
public static ToolCall from(
72-
String name, String type, String toolID, Map<String, Object> arguments) {
73-
return new ToolCall(name, type, toolID, arguments);
72+
String name, String type, String toolId, Map<String, Object> arguments) {
73+
return new ToolCall(name, type, toolId, arguments);
7474
}
7575

76-
private ToolCall(String name, String type, String toolID, Map<String, Object> arguments) {
76+
private ToolCall(String name, String type, String toolId, Map<String, Object> arguments) {
7777
this.name = name;
7878
this.type = type;
79-
this.toolID = toolID;
79+
this.toolId = toolId;
8080
this.arguments = arguments;
8181
}
8282

@@ -88,8 +88,8 @@ public String getType() {
8888
return type;
8989
}
9090

91-
public String getToolID() {
92-
return toolID;
91+
public String getToolId() {
92+
return toolId;
9393
}
9494

9595
public Map<String, Object> getArguments() {

dd-trace-api/src/main/java/datadog/trace/api/llmobs/noop/NoOpLLMObsSpanFactory.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,27 @@ public LLMObsSpan startLLMSpan(
1212
String modelName,
1313
String modelProvider,
1414
@Nullable String mlApp,
15-
@Nullable String sessionID) {
15+
@Nullable String sessionId) {
1616
return NoOpLLMObsSpan.INSTANCE;
1717
}
1818

1919
public LLMObsSpan startAgentSpan(
20-
String spanName, @Nullable String mlApp, @Nullable String sessionID) {
20+
String spanName, @Nullable String mlApp, @Nullable String sessionId) {
2121
return NoOpLLMObsSpan.INSTANCE;
2222
}
2323

2424
public LLMObsSpan startToolSpan(
25-
String spanName, @Nullable String mlApp, @Nullable String sessionID) {
25+
String spanName, @Nullable String mlApp, @Nullable String sessionId) {
2626
return NoOpLLMObsSpan.INSTANCE;
2727
}
2828

2929
public LLMObsSpan startTaskSpan(
30-
String spanName, @Nullable String mlApp, @Nullable String sessionID) {
30+
String spanName, @Nullable String mlApp, @Nullable String sessionId) {
3131
return NoOpLLMObsSpan.INSTANCE;
3232
}
3333

3434
public LLMObsSpan startWorkflowSpan(
35-
String spanName, @Nullable String mlApp, @Nullable String sessionID) {
35+
String spanName, @Nullable String mlApp, @Nullable String sessionId) {
3636
return NoOpLLMObsSpan.INSTANCE;
3737
}
3838
}

0 commit comments

Comments
 (0)