Skip to content

Commit 36b653b

Browse files
committed
rename LLM_OBS consts to be more aligned with other languages
1 parent 5259c28 commit 36b653b

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

dd-trace-api/src/main/java/datadog/trace/api/config/LlmObsConfig.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
*/
77
public final class LlmObsConfig {
88

9-
public static final String LLM_OBS_ENABLED = "llmobs.enabled";
9+
public static final String LLMOBS_ENABLED = "llmobs.enabled";
1010

11-
public static final String LLM_OBS_ML_APP = "llmobs.ml.app";
11+
public static final String LLMOBS_ML_APP = "llmobs.ml.app";
1212

13-
public static final String LLM_OBS_AGENTLESS_ENABLED = "llmobs.agentless.enabled";
13+
public static final String LLMOBS_AGENTLESS_ENABLED = "llmobs.agentless.enabled";
1414

1515
private LlmObsConfig() {}
1616
}

internal-api/src/main/java/datadog/trace/api/Config.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1341,8 +1341,8 @@ PROFILING_DATADOG_PROFILER_ENABLED, isDatadogProfilerSafeInCurrentEnvironment())
13411341
configProvider.getString(IAST_SECURITY_CONTROLS_CONFIGURATION, null);
13421342

13431343
llmObsAgentlessEnabled =
1344-
configProvider.getBoolean(LLM_OBS_AGENTLESS_ENABLED, DEFAULT_LLM_OBS_AGENTLESS_ENABLED);
1345-
llmObsMlApp = configProvider.getString(LLM_OBS_ML_APP);
1344+
configProvider.getBoolean(LLMOBS_AGENTLESS_ENABLED, DEFAULT_LLM_OBS_AGENTLESS_ENABLED);
1345+
llmObsMlApp = configProvider.getString(LLMOBS_ML_APP);
13461346

13471347
ciVisibilityTraceSanitationEnabled =
13481348
configProvider.getBoolean(CIVISIBILITY_TRACE_SANITATION_ENABLED, true);

internal-api/src/main/java/datadog/trace/api/InstrumenterConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import static datadog.trace.api.config.GeneralConfig.TRACE_TRIAGE;
2828
import static datadog.trace.api.config.GeneralConfig.TRIAGE_REPORT_TRIGGER;
2929
import static datadog.trace.api.config.IastConfig.IAST_ENABLED;
30-
import static datadog.trace.api.config.LlmObsConfig.LLM_OBS_ENABLED;
30+
import static datadog.trace.api.config.LlmObsConfig.LLMOBS_ENABLED;
3131
import static datadog.trace.api.config.ProfilingConfig.PROFILING_DIRECT_ALLOCATION_ENABLED;
3232
import static datadog.trace.api.config.ProfilingConfig.PROFILING_DIRECT_ALLOCATION_ENABLED_DEFAULT;
3333
import static datadog.trace.api.config.ProfilingConfig.PROFILING_ENABLED;
@@ -202,7 +202,7 @@ private InstrumenterConfig() {
202202
iastFullyDisabled = iastEnabled != null && !iastEnabled;
203203
usmEnabled = configProvider.getBoolean(USM_ENABLED, DEFAULT_USM_ENABLED);
204204
telemetryEnabled = configProvider.getBoolean(TELEMETRY_ENABLED, DEFAULT_TELEMETRY_ENABLED);
205-
llmObsEnabled = configProvider.getBoolean(LLM_OBS_ENABLED, DEFAULT_LLM_OBS_ENABLED);
205+
llmObsEnabled = configProvider.getBoolean(LLMOBS_ENABLED, DEFAULT_LLM_OBS_ENABLED);
206206
} else {
207207
// disable these features in native-image
208208
ciVisibilityEnabled = false;

internal-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ import static datadog.trace.api.config.JmxFetchConfig.JMX_FETCH_REFRESH_BEANS_PE
6363
import static datadog.trace.api.config.JmxFetchConfig.JMX_FETCH_STATSD_HOST
6464
import static datadog.trace.api.config.JmxFetchConfig.JMX_FETCH_STATSD_PORT
6565
import static datadog.trace.api.config.JmxFetchConfig.JMX_TAGS
66-
import static datadog.trace.api.config.LlmObsConfig.LLM_OBS_AGENTLESS_ENABLED
67-
import static datadog.trace.api.config.LlmObsConfig.LLM_OBS_ML_APP
68-
import static datadog.trace.api.config.LlmObsConfig.LLM_OBS_ENABLED
66+
import static datadog.trace.api.config.LlmObsConfig.LLMOBS_AGENTLESS_ENABLED
67+
import static datadog.trace.api.config.LlmObsConfig.LLMOBS_ML_APP
68+
import static datadog.trace.api.config.LlmObsConfig.LLMOBS_ENABLED
6969
import static datadog.trace.api.config.ProfilingConfig.PROFILING_AGENTLESS
7070
import static datadog.trace.api.config.ProfilingConfig.PROFILING_API_KEY_FILE_OLD
7171
import static datadog.trace.api.config.ProfilingConfig.PROFILING_API_KEY_FILE_VERY_OLD
@@ -2217,7 +2217,7 @@ class ConfigTest extends DDSpecification {
22172217
def "config instantiation should fail if llm obs is enabled via sys prop and ml app is not set"() {
22182218
setup:
22192219
Properties properties = new Properties()
2220-
properties.setProperty(LLM_OBS_ENABLED, "true")
2220+
properties.setProperty(LLMOBS_ENABLED, "true")
22212221

22222222
when:
22232223
new Config(ConfigProvider.withPropertiesOverride(properties))
@@ -2241,9 +2241,9 @@ class ConfigTest extends DDSpecification {
22412241
def "config instantiation should NOT fail if llm obs is enabled (agentless disabled) via sys prop and ml app is set"() {
22422242
setup:
22432243
Properties properties = new Properties()
2244-
properties.setProperty(LLM_OBS_ENABLED, "true")
2245-
properties.setProperty(LLM_OBS_AGENTLESS_ENABLED, "false")
2246-
properties.setProperty(LLM_OBS_ML_APP, "test-ml-app")
2244+
properties.setProperty(LLMOBS_ENABLED, "true")
2245+
properties.setProperty(LLMOBS_AGENTLESS_ENABLED, "false")
2246+
properties.setProperty(LLMOBS_ML_APP, "test-ml-app")
22472247
22482248
when:
22492249
def config = new Config(ConfigProvider.withPropertiesOverride(properties))
@@ -2273,9 +2273,9 @@ class ConfigTest extends DDSpecification {
22732273
def "config instantiation should fail if llm obs is in agentless mode via sys prop and API key is not set"() {
22742274
setup:
22752275
Properties properties = new Properties()
2276-
properties.setProperty(LLM_OBS_ENABLED, "true")
2277-
properties.setProperty(LLM_OBS_AGENTLESS_ENABLED, "true")
2278-
properties.setProperty(LLM_OBS_ML_APP, "test-ml-app")
2276+
properties.setProperty(LLMOBS_ENABLED, "true")
2277+
properties.setProperty(LLMOBS_AGENTLESS_ENABLED, "true")
2278+
properties.setProperty(LLMOBS_ML_APP, "test-ml-app")
22792279
22802280
when:
22812281
new Config(ConfigProvider.withPropertiesOverride(properties))
@@ -2300,9 +2300,9 @@ class ConfigTest extends DDSpecification {
23002300
def "config instantiation should NOT fail if llm obs is enabled (agentless enabled) and API key & ml app are set via sys prop"() {
23012301
setup:
23022302
Properties properties = new Properties()
2303-
properties.setProperty(LLM_OBS_ENABLED, "true")
2304-
properties.setProperty(LLM_OBS_AGENTLESS_ENABLED, "true")
2305-
properties.setProperty(LLM_OBS_ML_APP, "test-ml-app")
2303+
properties.setProperty(LLMOBS_ENABLED, "true")
2304+
properties.setProperty(LLMOBS_AGENTLESS_ENABLED, "true")
2305+
properties.setProperty(LLMOBS_ML_APP, "test-ml-app")
23062306
properties.setProperty(API_KEY, "123456789")
23072307
23082308
when:

0 commit comments

Comments
 (0)