Skip to content

Commit 2aad71f

Browse files
Minor refactoring of build scripts to use asm version from versions catalog. (#9688)
1 parent 27a157e commit 2aad71f

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

buildSrc/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ dependencies {
6262
implementation("com.github.zafarkhaja:java-semver:0.10.2")
6363

6464
implementation("com.google.guava", "guava", "20.0")
65-
implementation("org.ow2.asm", "asm", "9.9")
66-
implementation("org.ow2.asm", "asm-tree", "9.9")
65+
implementation(libs.asm)
66+
implementation(libs.asm.tree)
6767

6868
implementation(platform("com.fasterxml.jackson:jackson-bom:2.17.2"))
6969
implementation("com.fasterxml.jackson.core:jackson-databind")

buildSrc/call-site-instrumentation-plugin/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ dependencies {
3232
compileOnly("com.google.code.findbugs", "jsr305", "3.0.2")
3333

3434
implementation("org.freemarker", "freemarker", "2.3.30")
35-
implementation("org.ow2.asm", "asm", "9.9")
36-
implementation("org.ow2.asm", "asm-tree", "9.9")
35+
implementation(libs.asm)
36+
implementation(libs.asm.tree)
3737
implementation("com.github.javaparser", "javaparser-symbol-solver-core", "3.24.4")
3838

3939
testImplementation("net.bytebuddy", "byte-buddy", "1.17.5")

dd-java-agent/agent-debugger/build.gradle

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,9 @@ dependencies {
4444
implementation libs.dogstatsd
4545
implementation libs.moshi
4646

47+
testImplementation libs.asm.util
4748
testImplementation libs.bundles.junit5
48-
testImplementation group: 'org.ow2.asm', name: 'asm-util', version: libs.versions.asm.get()
49-
testImplementation group: "org.junit.jupiter", name: "junit-jupiter-params", version: libs.versions.junit5.get()
50-
testImplementation project(':dd-java-agent:agent-debugger:debugger-test-scala')
49+
testImplementation libs.junit.jupiter.params
5150
testImplementation libs.bundles.mockito
5251
testImplementation group: 'com.squareup.okhttp3', name: 'mockwebserver', version: libs.versions.okhttp.legacy.get()
5352
testImplementation group: 'org.springframework.boot', name: 'spring-boot', version: '2.3.5.RELEASE'
@@ -56,10 +55,13 @@ dependencies {
5655
testImplementation group: 'org.jooq', name: 'joor-java-8', version: '0.9.13'
5756
testImplementation group: 'org.jetbrains.kotlin', name: 'kotlin-compiler-embeddable', version: "2.1.21"
5857
testImplementation group: 'org.jetbrains.kotlinx', name: 'kotlinx-coroutines-core', version: "1.0.0"
58+
59+
testImplementation project(':dd-java-agent:agent-debugger:debugger-test-scala')
5960
testImplementation project(':dd-trace-core')
6061
testImplementation project(':dd-java-agent:agent-builder')
6162
testImplementation project(':remote-config:remote-config-core')
6263
testImplementation project(':utils:test-utils')
64+
6365
testRuntimeOnly group: 'org.scala-lang', name: 'scala-compiler', version: libs.versions.scala213.get()
6466
testRuntimeOnly group: 'antlr', name: 'antlr', version: '2.7.7'
6567
}

gradle/libs.versions.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ autoservice-annotation = { module = "com.google.auto.service:auto-service-annota
5050
commons-math = { module = "org.apache.commons:commons-math3", version.ref = "commons" }
5151
ddprof = { module = "com.datadoghq:ddprof", version.ref = "ddprof" }
5252
asm = { module = "org.ow2.asm:asm", version.ref = "asm" }
53+
asm-tree = { module = "org.ow2.asm:asm-tree", version.ref = "asm" }
54+
asm-util = { module = "org.ow2.asm:asm-util", version.ref = "asm" }
5355
asmcommons = { module = "org.ow2.asm:asm-commons", version.ref = "asm" }
5456
dogstatsd = { module = "com.datadoghq:java-dogstatsd-client", version.ref = "dogstatsd" }
5557
jnr-unixsocket = { module = "com.github.jnr:jnr-unixsocket", version.ref = "jnr-unixsocket"}

0 commit comments

Comments
 (0)