Skip to content

Commit 2768645

Browse files
Fix test
1 parent c8cda1d commit 2768645

File tree

3 files changed

+17
-5
lines changed

3 files changed

+17
-5
lines changed

dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/GatewayBridge.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,24 @@ public GatewayBridge(
131131
EventProducerService producerService,
132132
@Nonnull Supplier<ApiSecuritySampler> requestSamplerSupplier,
133133
List<TraceSegmentPostProcessor> traceSegmentPostProcessors) {
134+
this(
135+
subscriptionService,
136+
producerService,
137+
requestSamplerSupplier,
138+
null,
139+
traceSegmentPostProcessors);
140+
}
141+
142+
GatewayBridge(
143+
SubscriptionService subscriptionService,
144+
EventProducerService producerService,
145+
@Nonnull Supplier<ApiSecuritySampler> requestSamplerSupplier,
146+
ApiSecurityDownstreamSampler downstreamSampler,
147+
List<TraceSegmentPostProcessor> traceSegmentPostProcessors) {
134148
this.subscriptionService = subscriptionService;
135149
this.producerService = producerService;
136150
this.requestSamplerSupplier = requestSamplerSupplier;
151+
this.downstreamSampler = downstreamSampler;
137152
this.traceSegmentPostProcessors = traceSegmentPostProcessors;
138153
}
139154

@@ -1207,7 +1222,6 @@ private Flow<Void> maybePublishResponseData(AppSecRequestContext ctx) {
12071222

12081223
private ApiSecurityDownstreamSampler downstreamSampler() {
12091224
if (downstreamSampler == null) {
1210-
// we don't care about concurrency too much
12111225
downstreamSampler = new ApiSecurityDownstreamSamplerImpl();
12121226
}
12131227
return downstreamSampler;

dd-java-agent/appsec/src/test/groovy/com/datadog/appsec/gateway/GatewayBridgeIGRegistrationSpecification.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class GatewayBridgeIGRegistrationSpecification extends DDSpecification {
1010
SubscriptionService ig = Mock()
1111
EventDispatcher eventDispatcher = Mock()
1212

13-
GatewayBridge bridge = new GatewayBridge(ig, eventDispatcher, null, [])
13+
GatewayBridge bridge = new GatewayBridge(ig, eventDispatcher, null, null, [])
1414

1515
void 'request_body_start and request_body_done are registered'() {
1616
given:

dd-java-agent/appsec/src/test/groovy/com/datadog/appsec/gateway/GatewayBridgeSpecification.groovy

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,7 @@ class GatewayBridgeSpecification extends DDSpecification {
9292
TraceSegmentPostProcessor pp = Mock()
9393
ApiSecuritySamplerImpl requestSampler = Mock(ApiSecuritySamplerImpl)
9494
ApiSecurityDownstreamSampler downstreamSampler = Mock(ApiSecurityDownstreamSampler)
95-
GatewayBridge bridge = new GatewayBridge(ig, eventDispatcher, () -> requestSampler, [pp]).tap {
96-
it.downstreamSampler = downstreamSampler
97-
}
95+
GatewayBridge bridge = new GatewayBridge(ig, eventDispatcher, () -> requestSampler, downstreamSampler, [pp])
9896

9997
Supplier<Flow<AppSecRequestContext>> requestStartedCB
10098
BiFunction<RequestContext, AgentSpan, Flow<Void>> requestEndedCB

0 commit comments

Comments
 (0)