Skip to content

Commit 113e707

Browse files
Lower logging level for RepoIndex error (#9697)
1 parent 60a3b9d commit 113e707

File tree

4 files changed

+19
-12
lines changed

4 files changed

+19
-12
lines changed

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/source/index/RepoIndex.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ private String getFallbackSourcePath(@Nonnull Class<?> c) throws SourceResolutio
7070
try {
7171
String fileName = Utils.getFileName(c);
7272
if (fileName == null) {
73-
log.error("Could not retrieve file name for class {}", c.getName());
73+
log.debug("Could not retrieve file name for class {}", c.getName());
7474
return null;
7575
}
7676

dd-java-agent/instrumentation/junit/junit-4.10/src/test/groovy/JUnit4Test.groovy

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,15 @@ class JUnit4Test extends CiVisibilityInstrumentationTest {
7777

7878
where:
7979
testcaseName | success | tests | retriedTests
80-
// "test-failed" | false | [TestFailed] | []
80+
"test-failed" | false | [TestFailed] | []
8181
"test-retry-failed" | false | [TestFailed] | [new TestFQN("org.example.TestFailed", "test_failed")]
82-
// "test-failed-then-succeed" | true | [TestFailedThenSucceed] | [new TestFQN("org.example.TestFailedThenSucceed", "test_failed_then_succeed")]
83-
// "test-assumption-is-not-retried" | true | [TestAssumption] | [new TestFQN("org.example.TestAssumption", "test_fail_assumption")]
84-
// "test-skipped-is-not-retried" | true | [TestSkipped] | [new TestFQN("org.example.TestSkipped", "test_skipped")]
85-
// "test-retry-parameterized" | false | [TestFailedParameterized] | [
86-
// new TestFQN("org.example.TestFailedParameterized", "test_failed_parameterized") /* backend cannot provide parameters for flaky parameterized tests yet */
87-
// ]
88-
// "test-expected-exception-is-not-retried" | true | [TestSucceedExpectedException] | [new TestFQN("org.example.TestSucceedExpectedException", "test_succeed")]
82+
"test-failed-then-succeed" | true | [TestFailedThenSucceed] | [new TestFQN("org.example.TestFailedThenSucceed", "test_failed_then_succeed")]
83+
"test-assumption-is-not-retried" | true | [TestAssumption] | [new TestFQN("org.example.TestAssumption", "test_fail_assumption")]
84+
"test-skipped-is-not-retried" | true | [TestSkipped] | [new TestFQN("org.example.TestSkipped", "test_skipped")]
85+
"test-retry-parameterized" | false | [TestFailedParameterized] | [
86+
new TestFQN("org.example.TestFailedParameterized", "test_failed_parameterized") /* backend cannot provide parameters for flaky parameterized tests yet */
87+
]
88+
"test-expected-exception-is-not-retried" | true | [TestSucceedExpectedException] | [new TestFQN("org.example.TestSucceedExpectedException", "test_succeed")]
8989
}
9090

9191
def "test early flakiness detection #testcaseName"() {

dd-java-agent/instrumentation/junit/junit-4.10/src/test/resources/test-failed-then-succeed/events.ftl

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"test.command" : "junit-4.10",
1717
"test.framework" : "junit4",
1818
"test.framework_version" : ${content_meta_test_framework_version},
19-
"test.status" : "fail",
19+
"test.status" : "pass",
2020
"test.type" : "test",
2121
"test_session.name" : "session-name"
2222
},
@@ -48,7 +48,7 @@
4848
"test.framework" : "junit4",
4949
"test.framework_version" : ${content_meta_test_framework_version},
5050
"test.module" : "junit-4.10",
51-
"test.status" : "fail",
51+
"test.status" : "pass",
5252
"test.type" : "test",
5353
"test_session.name" : "session-name"
5454
},
@@ -80,7 +80,7 @@
8080
"test.framework_version" : ${content_meta_test_framework_version},
8181
"test.module" : "junit-4.10",
8282
"test.source.file" : "dummy_source_path",
83-
"test.status" : "fail",
83+
"test.status" : "pass",
8484
"test.suite" : "org.example.TestFailedThenSucceed",
8585
"test.type" : "test",
8686
"test_session.name" : "session-name"
@@ -118,6 +118,7 @@
118118
"runtime-id" : ${content_meta_runtime_id},
119119
"span.kind" : "test",
120120
"test.codeowners" : "[\"owner1\",\"owner2\"]",
121+
"test.failure_suppressed" : "true",
121122
"test.framework" : "junit4",
122123
"test.framework_version" : ${content_meta_test_framework_version},
123124
"test.module" : "junit-4.10",
@@ -168,6 +169,7 @@
168169
"runtime-id" : ${content_meta_runtime_id},
169170
"span.kind" : "test",
170171
"test.codeowners" : "[\"owner1\",\"owner2\"]",
172+
"test.failure_suppressed" : "true",
171173
"test.framework" : "junit4",
172174
"test.framework_version" : ${content_meta_test_framework_version},
173175
"test.is_retry" : "true",
@@ -220,6 +222,7 @@
220222
"runtime-id" : ${content_meta_runtime_id},
221223
"span.kind" : "test",
222224
"test.codeowners" : "[\"owner1\",\"owner2\"]",
225+
"test.failure_suppressed" : "true",
223226
"test.framework" : "junit4",
224227
"test.framework_version" : ${content_meta_test_framework_version},
225228
"test.is_retry" : "true",

dd-java-agent/instrumentation/junit/junit-4.10/src/test/resources/test-retry-parameterized/events.ftl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@
118118
"runtime-id" : ${content_meta_runtime_id},
119119
"span.kind" : "test",
120120
"test.codeowners" : "[\"owner1\",\"owner2\"]",
121+
"test.failure_suppressed" : "true",
121122
"test.framework" : "junit4",
122123
"test.framework_version" : ${content_meta_test_framework_version},
123124
"test.module" : "junit-4.10",
@@ -169,6 +170,7 @@
169170
"runtime-id" : ${content_meta_runtime_id},
170171
"span.kind" : "test",
171172
"test.codeowners" : "[\"owner1\",\"owner2\"]",
173+
"test.failure_suppressed" : "true",
172174
"test.framework" : "junit4",
173175
"test.framework_version" : ${content_meta_test_framework_version},
174176
"test.is_retry" : "true",
@@ -222,6 +224,7 @@
222224
"runtime-id" : ${content_meta_runtime_id},
223225
"span.kind" : "test",
224226
"test.codeowners" : "[\"owner1\",\"owner2\"]",
227+
"test.failure_suppressed" : "true",
225228
"test.framework" : "junit4",
226229
"test.framework_version" : ${content_meta_test_framework_version},
227230
"test.is_retry" : "true",
@@ -275,6 +278,7 @@
275278
"runtime-id" : ${content_meta_runtime_id},
276279
"span.kind" : "test",
277280
"test.codeowners" : "[\"owner1\",\"owner2\"]",
281+
"test.failure_suppressed" : "true",
278282
"test.framework" : "junit4",
279283
"test.framework_version" : ${content_meta_test_framework_version},
280284
"test.is_retry" : "true",

0 commit comments

Comments
 (0)