Skip to content

Commit 010dd57

Browse files
[mq] [skip ddci] working branch - merge d51e352 on top of master at 5447e79
{"baseBranch":"master","baseCommit":"5447e796c3c80bafbdd1369758601e7e44272936","createdAt":"2026-10-08T08:39:51.833073Z","headSha":"d51e3525176ad368fd30fc7fccd093f9f97cb347","id":"277c5f46-5d00-49d4-8c3e-418b7e7921bc","priority":"200","pullRequestNumber":"12753","queuedAt":"2026-10-08T08:39:51.831806Z","retryAttempt":"1","status":"STATUS_QUEUED"}
2 parents 7450520 + d51e352 commit 010dd57

7 files changed

Lines changed: 482 additions & 362 deletions

File tree

‎dd-java-agent/instrumentation/cucumber-5.4/build.gradle‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ muzzle {
1212
}
1313
}
1414

15+
addTestSuiteForDir('latest7Test', 'test')
1516
addTestSuiteForDir('latestDepTest', 'test')
1617

1718
dependencies {
@@ -26,4 +27,14 @@ dependencies {
2627

2728
latestDepTestImplementation group: 'io.cucumber', name: 'cucumber-java', version: '+'
2829
latestDepTestImplementation group: 'io.cucumber', name: 'cucumber-junit-platform-engine', version: '+'
30+
31+
latest7TestImplementation group: 'io.cucumber', name: 'cucumber-java', version: '7.+'
32+
latest7TestImplementation group: 'io.cucumber', name: 'cucumber-junit-platform-engine', version: '7.+'
33+
}
34+
35+
// cucumber 8.0.0+ requires Java 17
36+
tasks.named("latestDepTest", Test) {
37+
testJvmConstraints {
38+
minJavaVersion = JavaVersion.VERSION_17
39+
}
2940
}

‎dd-java-agent/instrumentation/cucumber-5.4/gradle.lockfile‎

Lines changed: 144 additions & 111 deletions
Large diffs are not rendered by default.

‎dd-java-agent/instrumentation/junit/junit-4/junit-4-cucumber-5.4/build.gradle‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ muzzle {
1111
}
1212
}
1313

14+
addTestSuiteForDir('latest7Test', 'test')
1415
addTestSuiteForDir('latestDepTest', 'test')
1516

1617
dependencies {
@@ -33,4 +34,14 @@ dependencies {
3334

3435
latestDepTestImplementation group: 'io.cucumber', name: 'cucumber-java', version: '+'
3536
latestDepTestImplementation group: 'io.cucumber', name: 'cucumber-junit', version: '+'
37+
38+
latest7TestImplementation group: 'io.cucumber', name: 'cucumber-java', version: '7.+'
39+
latest7TestImplementation group: 'io.cucumber', name: 'cucumber-junit', version: '7.+'
40+
}
41+
42+
// cucumber 8.0.0+ requires Java 17
43+
tasks.named("latestDepTest", Test) {
44+
testJvmConstraints {
45+
minJavaVersion = JavaVersion.VERSION_17
46+
}
3647
}

‎dd-java-agent/instrumentation/junit/junit-4/junit-4-cucumber-5.4/gradle.lockfile‎

Lines changed: 144 additions & 122 deletions
Large diffs are not rendered by default.

‎dd-java-agent/instrumentation/junit/junit-5/junit-5-cucumber-5.4/build.gradle‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ muzzle {
1414

1515
addTestSuiteForDir('cucumber723Test', 'test')
1616
addTestSuiteForDir('cucumber76Test', 'test')
17+
addTestSuiteForDir('latest7Test', 'test')
1718
addTestSuiteForDir('latestDepTest', 'test')
1819

1920
dependencies {
@@ -35,6 +36,9 @@ dependencies {
3536
latestDepTestImplementation group: 'io.cucumber', name: 'cucumber-java', version: '+'
3637
latestDepTestImplementation group: 'io.cucumber', name: 'cucumber-junit-platform-engine', version: '+'
3738

39+
latest7TestImplementation group: 'io.cucumber', name: 'cucumber-java', version: '7.+'
40+
latest7TestImplementation group: 'io.cucumber', name: 'cucumber-junit-platform-engine', version: '7.+'
41+
3842
cucumber76TestImplementation group: 'io.cucumber', name: 'cucumber-java', version: '7.6.0'
3943
cucumber76TestImplementation group: 'io.cucumber', name: 'cucumber-junit-platform-engine', version: '7.6.0'
4044

@@ -48,3 +52,10 @@ configurations.matching({ it.name.startsWith('test') || it.name.startsWith('cucu
4852
force group: 'org.junit.platform', name: 'junit-platform-suite', version: libs.versions.junit.platform.get()
4953
}
5054
})
55+
56+
// cucumber 8.0.0+ requires Java 17
57+
tasks.named("latestDepTest", Test) {
58+
testJvmConstraints {
59+
minJavaVersion = JavaVersion.VERSION_17
60+
}
61+
}

‎dd-java-agent/instrumentation/junit/junit-5/junit-5-cucumber-5.4/gradle.lockfile‎

Lines changed: 159 additions & 126 deletions
Large diffs are not rendered by default.

‎dd-java-agent/instrumentation/junit/junit-5/junit-5-cucumber-5.4/src/test/groovy/CucumberTest.groovy‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import datadog.trace.civisibility.CiVisibilityInstrumentationTest
55
import datadog.trace.instrumentation.junit5.JUnitPlatformUtils
66
import datadog.trace.instrumentation.junit5.TestEventsHandlerHolder
77
import datadog.trace.util.ComparableVersion
8-
import io.cucumber.core.api.TypeRegistry
98
import io.cucumber.core.options.Constants
109
import org.junit.platform.engine.DiscoverySelector
1110
import org.junit.platform.engine.TestExecutionResult
@@ -234,7 +233,7 @@ class CucumberTest extends CiVisibilityInstrumentationTest {
234233
}
235234

236235
private boolean usesFlatExampleNaming() {
237-
def version = TypeRegistry.package.getImplementationVersion()
236+
def version = Constants.package.getImplementationVersion()
238237
// 5.4.0 does not populate the package version; cucumber 7.11.0 switched from the flat
239238
// "Example #<row>" naming to "Example #<examplesBlock>.<row>".
240239
return version == null || new ComparableVersion(version) < new ComparableVersion("7.11.0")
@@ -282,7 +281,7 @@ class CucumberTest extends CiVisibilityInstrumentationTest {
282281

283282
@Override
284283
String instrumentedLibraryVersion() {
285-
def version = TypeRegistry.package.getImplementationVersion()
284+
def version = Constants.package.getImplementationVersion()
286285
return version != null ? version : "5.4.0" // older releases do not have package version populated
287286
}
288287

0 commit comments

Comments
 (0)