contrib/google.golang.org/grpc: benchmark for unary interceptor #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This benchmark attempts calls the gRPC interceptor with a few different set of inputs, to try and measure the current overhead of this operation. If this looks good, the goal would be to use this to confirm that some small tweaks actually have the desired effect. This was motivated when I noticed that the Datadog gRPC interceptor is about 0.5% of total CPU time, and about 0.4% of all allocations in one production application, as measured by the Datadog continuous profiler. I think there are a few easy small wins that are possible. I want to make sure we can measure the impact of these changes.
evanj
force-pushed
the
evan.jones/grpc-benchmark-unary
branch
from
1004870
to
b7d3b05
Compare
gbbr
approved these changes
Jan 20, 2022
|
Are we good to merge @evanj ? |
|
Yes, as far I know? This is a test-only change. I do not have permission to merge changes in this repository, so you'll have to do it for me. Thanks! |
|
Thanks for this @evanj ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This benchmark attempts calls the gRPC interceptor with a few
different set of inputs, to try and measure the current overhead of
this operation. If this looks good, the goal would be to use this to
confirm that some small tweaks actually have the desired effect.
This was motivated when I noticed that the Datadog gRPC interceptor
is about 0.5% of total CPU time, and about 0.4% of all allocations
in one production application, as measured by the Datadog continuous
profiler. I think there are a few easy small wins that are possible.
I want to make sure we can measure the impact of these changes.