Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSX-1006 fix s3 listobject issue visible in CloudTrail #836

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tyrcho
Copy link
Contributor

@tyrcho tyrcho commented Aug 14, 2024

What does this PR do?

Fix the wrong path declared in the CFT so the retry mechanism has access to the proper s3 prefix

Motivation

Issues reported by a few customers

Testing Guidelines

Additional Notes

I think the intent was to give ListBucket permission here but I'm a bit confused why we have 2 similar blocks
with different actions an resource id here and here.

Also I see in this commit that the ListBucket was removed from the first block by an external contributor.

In the change which was introduced 3 months ago to store and retry, there might be a mistake. IIUC, the call to list_objects uses the prefix failed_events while the template gives permission to the s3 prefix retry

The other prefix log-group-cache seems to be used properly from the other file you pointed out.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Aug 14, 2024
@tyrcho tyrcho force-pushed the michel.daviot/fix-s3-listobject branch 4 times, most recently from a6abfd5 to ad0b27f Compare August 14, 2024 13:47
@tyrcho tyrcho changed the title fix s3 listobject issue visible in CloudTrail AWSX-1006 fix s3 listobject issue visible in CloudTrail Aug 14, 2024
@tyrcho tyrcho force-pushed the michel.daviot/fix-s3-listobject branch from 1f17198 to 949e630 Compare August 16, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant