Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable enhanced metric by setting an environment variable DD_SUBMIT_ENHANCED_METRICS to false #769

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

perzycharles
Copy link
Contributor

If the forwarder has another function log group as a trigger, enhanced lambda metric of another function would be generated, which is confusing because this will cause the other function to appear in the Serverless page.

What does this PR do?

This PR would allow customer to disable enhanced metric by simply setting an environment variable DD_SUBMIT_ENHANCED_METRICS to false

Motivation

Jira issues CLOUDS-4535/CLOUDS-4529

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@perzycharles perzycharles requested a review from a team as a code owner April 9, 2024 08:18
@github-actions github-actions bot added the aws label Apr 9, 2024
kimi-p
kimi-p approved these changes Apr 9, 2024
@kimi-p
Copy link
Contributor

kimi-p commented Apr 9, 2024

Wait. I think this variable is a already being used? Is the plan to overload the old env var with this enablement?

DD_SUBMIT_ENHANCED_METRICS = True

Copy link
Contributor

@kimi-p kimi-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DD_SUBMIT_ENHANCED_METRICS is already used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants