Fix ListServiceDefinitions pagination information (#1550)

Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com>

Author: api-clients-generation-pipeline[bot]

.apigentools-info

@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.6.6",
-            "regenerated": "2024-03-07 14:48:11.719468",
-            "spec_repo_commit": "dbf17f07"
+            "regenerated": "2024-03-07 16:40:15.030371",
+            "spec_repo_commit": "ba5b230c"
         },
         "v2": {
             "apigentools_version": "1.6.6",
-            "regenerated": "2024-03-07 14:48:11.735278",
-            "spec_repo_commit": "dbf17f07"
+            "regenerated": "2024-03-07 16:40:15.047368",
+            "spec_repo_commit": "ba5b230c"
         }
     }
 }

.generator/schemas/v2/openapi.yaml

@@ -32455,7 +32455,7 @@ paths:
       - Service Definition
       x-pagination:
         limitParam: page[size]
-        pageOffsetParam: page[number]
+        pageParam: page[number]
         resultsPath: data
     post:
       description: Create or update service definition in the Datadog Service Catalog.

cassettes/v2/Service-Definition_2211895093/Get-all-service-definitions-returns-OK-response-with-pagination_993577015/recording.har

@@ -8,7 +8,7 @@
     },
     "entries": [
       {
-        "_id": "2e4420ff858de0f4313ccbc92eb665f7",
+        "_id": "570fd209d1660bd571045dafd2de9a93",
         "_order": 0,
         "cache": {},
         "request": {
@@ -28,11 +28,12 @@
             {
               "name": "page",
               "value": {
+                "number": "0",
                 "size": "2"
               }
             }
           ],
-          "url": "https://api.datadoghq.com/api/v2/services/definitions?page%5Bsize%5D=2"
+          "url": "https://api.datadoghq.com/api/v2/services/definitions?page%5Bsize%5D=2&page%5Bnumber%5D=0"
         },
         "response": {
           "bodySize": 2155,
@@ -58,7 +59,7 @@
         "time": 468
       },
       {
-        "_id": "1c6d4b2001a98d9de4400911acda2436",
+        "_id": "834bf021fc4f484c0320b36a22143712",
         "_order": 0,
         "cache": {},
         "request": {
@@ -78,12 +79,12 @@
             {
               "name": "page",
               "value": {
-                "number": "2",
+                "number": "1",
                 "size": "2"
               }
             }
           ],
-          "url": "https://api.datadoghq.com/api/v2/services/definitions?page%5Bsize%5D=2&page%5Bnumber%5D=2"
+          "url": "https://api.datadoghq.com/api/v2/services/definitions?page%5Bsize%5D=2&page%5Bnumber%5D=1"
         },
         "response": {
           "bodySize": 2636,

packages/datadog-api-client-v2/apis/ServiceDefinitionApi.ts

@@ -614,6 +614,7 @@ export class ServiceDefinitionApi {
       pageSize = param.pageSize;
     }
     param.pageSize = pageSize;
+    param.pageNumber = 0;
     while (true) {
       const requestContext = await this.requestFactory.listServiceDefinitions(
         param.pageSize,
@@ -639,11 +640,7 @@ export class ServiceDefinitionApi {
       if (results.length < pageSize) {
         break;
       }
-      if (param.pageNumber === undefined) {
-        param.pageNumber = pageSize;
-      } else {
-        param.pageNumber = param.pageNumber + pageSize;
-      }
+      param.pageNumber = param.pageNumber + 1;
     }
   }
 }